All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff Garzik <jeff@garzik.org>
To: Tejun Heo <htejun@gmail.com>
Cc: IDE/ATA development list <linux-ide@vger.kernel.org>
Subject: Re: [PATCH #upstream-fixes] ata_piix: ignore ATA_DMA_ERR on vmware ich4
Date: Thu, 10 Jan 2008 16:50:11 -0500	[thread overview]
Message-ID: <47869313.7060306@garzik.org> (raw)
In-Reply-To: <4782013D.7010304@gmail.com>

Tejun Heo wrote:
> VMware ich4 emulation incorrectly sets DMA_ERR on TF error.  Ignore
> it.
> 
> Signed-off-by: Tejun Heo <htejun@gmail.com>

hrm.  IIRC, the old-IDE code just sorta ignores this, and in the 
original libata I followed old-IDE's habit of acking events with

	write-to-dma-status-register(err | intr)

so what part of libata-core cares about this distinction?  what is the 
specific behavior from the original problem report that this solves?

	Jeff




  reply	other threads:[~2008-01-10 21:50 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-07 10:38 [PATCH #upstream-fixes] ata_piix: ignore ATA_DMA_ERR on vmware ich4 Tejun Heo
2008-01-10 21:50 ` Jeff Garzik [this message]
2008-01-11  1:00   ` Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47869313.7060306@garzik.org \
    --to=jeff@garzik.org \
    --cc=htejun@gmail.com \
    --cc=linux-ide@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.