From: Roel Kluin <12o3l@tiscali.nl>
To: Randy Dunlap <randy.dunlap@oracle.com>
Cc: linville@tuxdriver.com, lkml <linux-kernel@vger.kernel.org>,
linux-wireless@vger.kernel.org, Elmer.Joandi@ut.ee,
c.jennings@ieee.org
Subject: Re: [PATCH wireless/arlan] Replace logical- by bit-and
Date: Thu, 10 Jan 2008 23:19:28 +0100 [thread overview]
Message-ID: <478699F0.9070306@tiscali.nl> (raw)
In-Reply-To: <20080110122859.569b3774.randy.dunlap@oracle.com>
Randy Dunlap wrote:
> On Thu, 10 Jan 2008 20:15:53 +0100 Roel Kluin wrote:
>
>> diff --git a/drivers/net/wireless/arlan.h b/drivers/net/wireless/arlan.h
>> index 3ed1df7..7b7498f 100644
>> --- a/drivers/net/wireless/arlan.h
>> +++ b/drivers/net/wireless/arlan.h
>> @@ -485,7 +485,7 @@ struct arlan_private {
>> #define clearClearInterrupt(dev){\
>> writeControlRegister(dev,readControlRegister(dev) & ~ARLAN_CLEAR_INTERRUPT);}
>> #define setPowerOff(dev){\
>> - writeControlRegister(dev,readControlRegister(dev) | (ARLAN_POWER && ARLAN_ACCESS));\
>> + writeControlRegister(dev, readControlRegister(dev) | (ARLAN_POWER & ARLAN_ACCESS));\
>
> eh? How does that help?
Right, sorry, please ignore my patch.
> Maybe it should be (ARLAN_POWER | ARLAN_ACCESS), but some
> arlan developer or someone with specs should help here...
I have CC'd the previous maintainers
next prev parent reply other threads:[~2008-01-10 22:19 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-26 19:51 [PATCH] fix 'and' typo's Roel Kluin
2007-10-26 20:06 ` [PATCH split 0/8] " Roel Kluin
2007-10-26 20:07 ` [PATCH split 1/8] fix 'and' typo's in airo wireless Roel Kluin
2007-10-26 20:09 ` [PATCH split 2/8] fix 'and' typo's in atmel wireless Roel Kluin
2007-10-26 20:12 ` [PATCH split 3/8] fix 'and' typo's in wireless/libertas/wext Roel Kluin
2007-10-26 20:13 ` [PATCH split 4/8] fix 'and' typo's in wireless/p54common Roel Kluin
2007-10-26 20:14 ` [PATCH split 5/8] fix 'and' typo's wireless/prism54/isl_ioctl (first) Roel Kluin
2007-10-29 15:11 ` Luis R. Rodriguez
2007-10-26 20:18 ` [PATCH split 6/8] fix 'and' typo's Roel Kluin
2007-10-26 20:19 ` [PATCH split 7/8] fix 'and' typo's in wireless/zd1211rw/zd_rf_uw2453 Roel Kluin
2007-10-26 20:19 ` [PATCH split 8/8] fix 'and' typo's net/ieee80211/ieee80211_wx Roel Kluin
2008-01-10 19:15 ` [PATCH wireless/arlan] Replace logical- by bit-and Roel Kluin
2008-01-10 20:28 ` Randy Dunlap
2008-01-10 20:48 ` Chuck Ebbert
2008-01-10 21:16 ` Randy Dunlap
2008-01-10 21:28 ` John W. Linville
2008-01-10 22:19 ` Roel Kluin [this message]
2007-10-26 23:48 ` [PATCH] fix 'and' typo's Dan Williams
2007-10-27 0:05 ` Roel Kluin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=478699F0.9070306@tiscali.nl \
--to=12o3l@tiscali.nl \
--cc=Elmer.Joandi@ut.ee \
--cc=c.jennings@ieee.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=randy.dunlap@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.