All of lore.kernel.org
 help / color / mirror / Atom feed
From: Scott Wood <scottwood@freescale.com>
To: Grant Likely <grant.likely@secretlab.ca>
Cc: olof@lixom.net, linuxppc-dev@ozlabs.org,
	alsa-devel@alsa-project.org, Timur Tabi <timur@freescale.com>,
	david@gibson.dropbear.id.au
Subject: Re: [PATCH v3] [POWERPC] Update MPC8610 HPCD to support audio drivers
Date: Thu, 10 Jan 2008 17:00:12 -0600	[thread overview]
Message-ID: <4786A37C.2040905@freescale.com> (raw)
In-Reply-To: <fa686aa40801101452q608907f3rf6f98a5d091d09d9@mail.gmail.com>

Grant Likely wrote:
>> +                dma@21300 {
>> +                        #address-cells = <1>;
>> +                        #size-cells = <1>;
>> +                        compatible = "fsl,mpc8610-dma", "fsl,eloplus-dma";
>> +                        cell-index = <0>;
>> +                        reg = <21300 4>; /* DMA general status register */
>> +                        ranges = <0 21100 200>;
>> +
>> +                        dma-channel@0 {
>> +                               compatible = "fsl,mpc8610-dma-channel",
>> +                                       "fsl,eloplus-dma-channel";
> 
> Nit: you probably don't need the compatible property for these channel
> nodes since they are 100% dependent on the parent for describing the
> behaviour.

The compatible property in the child nodes gives the driver the option 
of matching the channel rather than the whole thing.

-Scott

  reply	other threads:[~2008-01-10 23:42 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-10 22:44 [PATCH 0/2] ASoC drivers for the Freescale MPC8610 SoC Timur Tabi
2008-01-10 22:44 ` [PATCH v3] [POWERPC] Update MPC8610 HPCD to support audio drivers Timur Tabi
2008-01-10 22:44   ` [PATCH v2] [ALSA] Add ASoC drivers for the Freescale MPC8610 SoC Timur Tabi
2008-01-10 23:02     ` Grant Likely
2008-01-10 23:12       ` Timur Tabi
2008-01-10 23:12         ` [alsa-devel] " Timur Tabi
2008-01-10 23:17         ` Grant Likely
2008-01-10 23:17           ` [alsa-devel] " Grant Likely
2008-01-10 23:19           ` Timur Tabi
2008-01-10 23:19             ` [alsa-devel] " Timur Tabi
2008-01-11  0:24         ` Olof Johansson
2008-01-11  0:24           ` [alsa-devel] " Olof Johansson
2008-01-11 15:08           ` Timur Tabi
2008-01-11 15:08             ` [alsa-devel] " Timur Tabi
2008-01-10 22:52   ` [PATCH v3] [POWERPC] Update MPC8610 HPCD to support audio drivers Grant Likely
2008-01-10 23:00     ` Scott Wood [this message]
2008-01-11 16:39     ` Timur Tabi
2008-01-11 16:44       ` Takashi Iwai
2008-01-11 17:07         ` Timur Tabi
2008-01-11 17:12           ` Takashi Iwai
2008-01-11 17:16             ` Timur Tabi
2008-01-11 17:20               ` Takashi Iwai
2008-01-11 17:23               ` Jaroslav Kysela
2008-01-12 13:40                 ` Mark Brown
2008-01-18  6:48   ` Kumar Gala
2008-01-18 14:48     ` Timur Tabi
2008-01-18 14:48       ` [alsa-devel] " Timur Tabi
2008-01-18 15:18       ` Kumar Gala
2008-01-18 15:18         ` [alsa-devel] " Kumar Gala
2008-01-18 15:40         ` Takashi Iwai
2008-01-18 15:40           ` [alsa-devel] " Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4786A37C.2040905@freescale.com \
    --to=scottwood@freescale.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=david@gibson.dropbear.id.au \
    --cc=grant.likely@secretlab.ca \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=olof@lixom.net \
    --cc=timur@freescale.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.