From: Jun'ichi Nomura <j-nomura@ce.jp.nec.com>
To: lvm-devel@redhat.com
Subject: [PATCH 11/11] Fix _remove_mirror_images() to skip AREA_LV
Date: Fri, 11 Jan 2008 18:49:46 -0500 [thread overview]
Message-ID: <4788009A.1070405@ce.jp.nec.com> (raw)
In-Reply-To: <4787FA27.8050300@ce.jp.nec.com>
Do not remove mirror image on AREA_LV.
If the mirror image LV consists of AREA_LV, current version
of remove_mirror_images() always remove it ignoring removable_pvs
constraint.
That's not correct.
The FIXME comment suggests recursing down the AREA_LV.
However, it might not be sufficient if we can have LVs with
different structure.
Currently, we won't hit this check.
So just leave it for safety side.
--
Jun'ichi Nomura, NEC Corporation of America
-------------- next part --------------
A non-text attachment was scrubbed...
Name: fix-remove_mirror_images-dont-remove-stacked-mirror.patch
Type: text/x-patch
Size: 1048 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/lvm-devel/attachments/20080111/4e8342fa/attachment.bin>
next prev parent reply other threads:[~2008-01-11 23:49 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-11 23:22 [PATCH 0/11] updates to stacking and lvconvert Jun'ichi Nomura
2008-01-11 23:43 ` [PATCH 1/11] lvconvert takes '--wait' instead of '--background' Jun'ichi Nomura
2008-01-12 1:48 ` [PATCH 14/14] lvconvert help message wasn't fixed to '--wait' Jun'ichi Nomura
2008-01-14 14:29 ` [PATCH 1/11] lvconvert takes '--wait' instead of '--background' Alasdair G Kergon
2008-01-14 17:03 ` Jun'ichi Nomura
2008-01-11 23:44 ` [PATCH 2/11] Add upward link from underlying LV to stacked seg Jun'ichi Nomura
2008-01-12 1:48 ` [PATCH 12/14] Do not make extra call to lv_add_user_seg() Jun'ichi Nomura
2008-01-14 22:39 ` [PATCH 2/11] Add upward link from underlying LV to stacked seg Alasdair G Kergon
2008-01-14 22:53 ` Alasdair G Kergon
2008-01-15 16:39 ` Jun'ichi Nomura
2008-01-15 16:56 ` Alasdair G Kergon
2008-01-15 19:54 ` Jun'ichi Nomura
2008-01-15 22:42 ` Jun'ichi Nomura
2008-01-11 23:45 ` [PATCH 3/11] Move mirror log initialization functions Jun'ichi Nomura
2008-01-11 23:45 ` [PATCH 4/11] Move _find_tmp_mirror() Jun'ichi Nomura
2008-01-11 23:46 ` [PATCH 5/11] Move removable_pvs checking Jun'ichi Nomura
2008-01-11 23:46 ` [PATCH 6/11] Export find_tmp_mirror() Jun'ichi Nomura
2008-01-11 23:47 ` [PATCH 7/11] lvconvert adds/removes mirror log to/from the original LV Jun'ichi Nomura
2008-01-12 1:48 ` [PATCH 13/14] lvconvert should check first_seg(original_lv) Jun'ichi Nomura
2008-01-16 20:46 ` Jun'ichi Nomura
2008-01-11 23:48 ` [PATCH 8/11] Allow "mirror" segment with only 1 area Jun'ichi Nomura
2008-01-11 23:48 ` [PATCH 9/11] _init_mirror_log() to cope with activation status Jun'ichi Nomura
2008-01-11 23:49 ` [PATCH 10/11] Fix _remove_mirror_images() to cope with stacked mirror Jun'ichi Nomura
2008-01-11 23:49 ` Jun'ichi Nomura [this message]
2008-01-11 23:56 ` [Test case 1/2] Basic mirrored LV testing Jun'ichi Nomura
2008-01-11 23:56 ` [Test case 2/2] lvconvert mirror-addition testing Jun'ichi Nomura
2008-01-15 23:12 ` Jun'ichi Nomura
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4788009A.1070405@ce.jp.nec.com \
--to=j-nomura@ce.jp.nec.com \
--cc=lvm-devel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.