From: Jim Ramsay <jim.ramsay@gmail.com>
To: Lukasz Kosewski <lkosewsk@gmail.com>
Cc: Stefan Richter <stefanr@s5r6.in-berlin.de>,
linux-scsi@vger.kernel.org, linux-ide@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] Add disk hotswap support to libata RESEND #2
Date: Wed, 24 Aug 2005 10:12:31 -0600 [thread overview]
Message-ID: <4789af9e05082409121cc6870@mail.gmail.com> (raw)
In-Reply-To: <4789af9e05082408111c4a6294@mail.gmail.com>
On 8/24/05, Jim Ramsay <jim.ramsay@gmail.com> wrote:
> On 8/24/05, Lukasz Kosewski <lkosewsk@gmail.com> wrote:
> > On 8/24/05, Stefan Richter <stefanr@s5r6.in-berlin.de> wrote:
> > > >> Timers appear to operate in an atomic context, so timers should not be
> > > >> allowed to call scsi_remove_device, which eventually schedules.
> > > >>
> > > >> Any suggestions on the best way to fix this?
> > > >
> > > > Workqueue, perhaps.
> >
> > Perhaps. Actually, of course :)
>
> How about the existing ata_wq workqueue? This makes sense. When the
> timer expires, it adds a task to this queue.
Note to self - No, you cannot use the exsting 'ata_wq' workqueue - The
plug-in events need to put other work on the queue during the hotplug
event... and of course this deadlocks since you're in the queuethread
already.
--
Jim Ramsay
"Me fail English? That's unpossible!"
next prev parent reply other threads:[~2005-08-24 16:12 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-08-01 10:02 [PATCH 3/3] Add disk hotswap support to libata RESEND #2 Lukasz Kosewski
2005-08-23 19:41 ` Jim Ramsay
2005-08-23 22:43 ` Jim Ramsay
2005-08-23 22:56 ` George Anzinger
2005-08-24 1:20 ` Stefan Richter
2005-08-24 14:03 ` Lukasz Kosewski
2005-08-24 15:11 ` Jim Ramsay
2005-08-24 16:12 ` Jim Ramsay [this message]
[not found] ` <4789af9e0508291223435f174@mail.gmail.com>
2005-08-29 19:45 ` Jim Ramsay
2005-09-06 19:02 ` Jim Ramsay
2005-09-15 4:40 ` Lukasz Kosewski
2005-09-16 16:11 ` Mark Lord
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4789af9e05082409121cc6870@mail.gmail.com \
--to=jim.ramsay@gmail.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=lkosewsk@gmail.com \
--cc=stefanr@s5r6.in-berlin.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.