From: Johannes Sixt <j.sixt@viscovery.net>
To: Martin Koegler <mkoegler@auto.tuwien.ac.at>
Cc: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: [PATCH] parse_commit_buffer: don't parse invalid commits
Date: Tue, 15 Jan 2008 08:32:59 +0100 [thread overview]
Message-ID: <478C61AB.2040103@viscovery.net> (raw)
In-Reply-To: <12003456313661-git-send-email-mkoegler@auto.tuwien.ac.at>
Martin Koegler schrieb:
> Signed-off-by: Martin Koegler <mkoegler@auto.tuwien.ac.at>
Quite a lot has been said about this change and you had a hard time
defending it. Why doesn't *anything* of that discussion end up in the
commit message? The absolute minimum that belongs there is your definition
of "invalid commit".
-- Hannes
next prev parent reply other threads:[~2008-01-15 7:33 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-14 21:20 [PATCH] parse_commit_buffer: don't parse invalid commits Martin Koegler
2008-01-15 7:32 ` Johannes Sixt [this message]
-- strict thread matches above, loose matches on Subject: below --
2008-01-19 17:35 Martin Koegler
2008-01-19 19:52 ` Junio C Hamano
2008-01-20 16:11 ` Martin Koegler
2008-01-06 19:03 [PATCH] parse_tag_buffer: don't parse invalid tags Martin Koegler
2008-01-06 19:03 ` [PATCH] parse_commit_buffer: don't parse invalid commits Martin Koegler
2008-01-06 22:00 ` Junio C Hamano
2008-01-07 7:40 ` Martin Koegler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=478C61AB.2040103@viscovery.net \
--to=j.sixt@viscovery.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=mkoegler@auto.tuwien.ac.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.