From: Patrick McHardy <kaber@trash.net>
To: Jarek Poplawski <jarkao2@gmail.com>
Cc: Badalian Vyacheslav <slavon@bigtelecom.ru>, netdev@vger.kernel.org
Subject: Re: Packetlost when "tc qdisc del dev eth0 root"
Date: Wed, 16 Jan 2008 06:02:00 +0100 [thread overview]
Message-ID: <478D8FC8.9000107@trash.net> (raw)
In-Reply-To: <478D226E.1050209@gmail.com>
Jarek Poplawski wrote:
> Patrick McHardy wrote, On 01/15/2008 05:05 PM:
>
>> Badalian Vyacheslav wrote:
>
> ...
>
>> Yes, packets in the old qdisc are lost.
>>
>>> Maybe if tc do changes - need create second queue (hash of rules or how
>>> you named it?) and do changes at it. Then replace old queue rules by
>>> created new.
>>> Logic -
>>> 1. Do snapshot
>>> 2. Do changes in shapshot
>>> 3. All new packets go to snapshot
>>> 4. If old queue not have packets - delete it.
>>> 5. Snapshot its default.
>>
>> That doesn't really work since qdiscs keep internal state that
>> in large parts depends on the packets queued. Take the qlen as
>> a simple example, the new qdisc doesn't know about the packets
>> in the old one and will exceed the limit.
>
> But, some similar alternative to killing packets 'to death' could
> be imagined, I suppose (in the future, of course!). So, e.g. doing
> the switch automatically after last packet has been dequeued (maybe
> even with some 'special' function/mode for this). After all even
> with accuracy lost, it could be less visible for clients than
> current way?
This would need support from the qdiscs to do it properly. Looks
non-trivial for HTB/HFSC/CBQ, but the others shouldn't be that hard.
next prev parent reply other threads:[~2008-01-16 5:02 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-15 11:10 Packetlost when "tc qdisc del dev eth0 root" Badalian Vyacheslav
2008-01-15 16:05 ` Patrick McHardy
2008-01-15 16:11 ` slavon
2008-01-15 21:15 ` Jarek Poplawski
2008-01-15 21:46 ` slavon
2008-01-15 22:04 ` slavon
2008-01-15 22:49 ` Jarek Poplawski
2008-01-16 5:12 ` Patrick McHardy
2008-01-19 23:21 ` Jarek Poplawski
2008-01-15 22:32 ` Jarek Poplawski
2008-01-15 23:16 ` Glen Turner
2008-01-16 5:02 ` Patrick McHardy [this message]
2008-01-16 8:02 ` Jarek Poplawski
2008-01-16 8:05 ` Patrick McHardy
2008-01-16 8:35 ` Badalian Vyacheslav
2008-01-16 9:42 ` Jarek Poplawski
2008-01-16 8:52 ` Jarek Poplawski
2008-01-16 8:54 ` Badalian Vyacheslav
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=478D8FC8.9000107@trash.net \
--to=kaber@trash.net \
--cc=jarkao2@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=slavon@bigtelecom.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.