From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pavel Emelyanov Subject: Re: [PATCH] An attempt to have an unlimitedly extendable sys_clone Date: Wed, 16 Jan 2008 10:26:36 +0300 Message-ID: <478DB1AC.6050508@openvz.org> References: <478CAC32.4080809@openvz.org> <39689.192.168.101.12.1200407681.squirrel@intranet> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <39689.192.168.101.12.1200407681.squirrel@intranet> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Daniel Hokka Zakrisson Cc: Linux Containers , Cedric Le Goater List-Id: containers.vger.kernel.org [snip] >> +static struct long_clone_arg *get_long_clone_arg(int __user >> *child_tidptr) >> +{ >> + int size; >> + struct long_clone_arg *carg; >> + >> + if (get_user(size, child_tidptr)) >> + return ERR_PTR(-EFAULT); >> + >> + if (size > sizeof(struct long_clone_arg)) >> + return ERR_PTR(-EINVAL); > > This means that software built against a newer kernel won't work on an > older one. Surely that's not intended? It is intended. If I ask an old kernel to clone the mq namespace, but it doesn't support such, that I'd better like to get an -EINVAL error rather than be silently held in an old global namespace. [snip]