Re: [Qemu-devel] [PATCH] add VNC reverse connections

[Anthony Liguori <anthony@codemonkey.ws>]

Eddie Kohler wrote:
> Daniel P. Berrange wrote:
>> We already have the ability to pass multiple flags / options to the VNC
>> driver as a post-fix to the host:port pair, so I'm not a fan of 
>> introducing
>> a new option as a prefix. If using existing options syntax, it could 
>> look
>> like:
>>
>>   -vnc :5500,rev
>>   -vnc read.cs.ucla.edu:5500,rev
>
> This doesn't feel like an option to me, though; rather a different 
> means of connecting.  Among other things, in "-vnc :0", the QEMU VNC 
> server opens port 5900.  But the client's listening port for reverse 
> connections defaults to 5500.  "-vnc :-400,rev" is clearly insane, but 
> it seems strange for an option like ",rev" to change the meaning of 
> the port field.
>
> If you still disagree I'll produce a patch with ",reverse" as an option.

I'm not a huge fan of the "option,mod,mod" syntax but Dan is right, it's 
what is used in QEMU.  Consistency is often times better than sanity :-)

Regards,

Anthony Liguori

> Eddie
>
>