From: "Jan Beulich" <jbeulich@novell.com>
To: Keir Fraser <Keir.Fraser@cl.cam.ac.uk>
Cc: xen-devel@lists.xensource.com
Subject: Re: linux: {start, stop}_hz_timer() not really affecting periodic timer?
Date: Wed, 16 Jan 2008 17:17:38 +0000 [thread overview]
Message-ID: <478E4A42.76E4.0078.0@novell.com> (raw)
In-Reply-To: <C3B3E562.1AEAE%Keir.Fraser@cl.cam.ac.uk>
>>> Keir Fraser <Keir.Fraser@cl.cam.ac.uk> 16.01.08 17:46 >>>
>On 16/1/08 16:36, "Jan Beulich" <jbeulich@novell.com> wrote:
>
>>> If the time is in the past then the singleshot timer will fire immediately.
>>> So you'll take a slower path than necessary, but the code as-is will work
>>> fine.
>>
>> Immediately would mean to me that it would fire on the return path
>> from VCPUOP_set_singleshot_timer, so HYPERVISOR_block() would
>> not (necessarily) find any pending events and hence block when it
>> shouldn't. Or am I missing some magic by which this is being avoided?
>
>The function should only be called with interrupts disabled.
That goes back to what I stated first - there's nothing really requiring
this, it just happens to be that way at present.
Jan
next prev parent reply other threads:[~2008-01-16 17:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-16 14:32 linux: {start, stop}_hz_timer() not really affecting periodic timer? Jan Beulich
2008-01-16 14:37 ` Keir Fraser
2008-01-16 15:50 ` Jan Beulich
2008-01-16 15:54 ` Keir Fraser
2008-01-16 16:36 ` Jan Beulich
2008-01-16 16:46 ` Keir Fraser
2008-01-16 17:17 ` Jan Beulich [this message]
2008-01-16 18:26 ` Keir Fraser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=478E4A42.76E4.0078.0@novell.com \
--to=jbeulich@novell.com \
--cc=Keir.Fraser@cl.cam.ac.uk \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.