From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1JFIFW-0003Wp-35
	for qemu-devel@nongnu.org; Wed, 16 Jan 2008 19:04:50 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1JFIFT-0003WU-IG
	for qemu-devel@nongnu.org; Wed, 16 Jan 2008 19:04:48 -0500
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1JFIFT-0003WR-C0
	for qemu-devel@nongnu.org; Wed, 16 Jan 2008 19:04:47 -0500
Received: from an-out-0708.google.com ([209.85.132.241])
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1JFIFS-0004jo-S7
	for qemu-devel@nongnu.org; Wed, 16 Jan 2008 19:04:47 -0500
Received: by an-out-0708.google.com with SMTP id b38so128165ana.130
	for <qemu-devel@nongnu.org>; Wed, 16 Jan 2008 16:04:46 -0800 (PST)
Message-ID: <478E9BA5.8090704@codemonkey.ws>
Date: Wed, 16 Jan 2008 18:04:53 -0600
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH] add VNC reverse connections
References: <478DB1D3.60905@cs.ucla.edu>
	<20080116124231.GB16624@redhat.com>	<478E1E0F.1040303@cs.ucla.edu>
	<20080116163539.GA27604@redhat.com>
In-Reply-To: <20080116163539.GA27604@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Daniel P. Berrange" <berrange@redhat.com>, qemu-devel@nongnu.org
Cc: Eddie Kohler <kohler@cs.ucla.edu>

Daniel P. Berrange wrote:
> On Wed, Jan 16, 2008 at 07:09:03AM -0800, Eddie Kohler wrote:
>   
>> Daniel P. Berrange wrote:
>>     
>>> We already have the ability to pass multiple flags / options to the VNC
>>> driver as a post-fix to the host:port pair, so I'm not a fan of introducing
>>> a new option as a prefix. If using existing options syntax, it could look
>>> like:
>>>
>>>  -vnc :5500,rev
>>>  -vnc read.cs.ucla.edu:5500,rev
>>>       
>> This doesn't feel like an option to me, though; rather a different means of 
>> connecting.  Among other things, in "-vnc :0", the QEMU VNC server opens 
>> port 5900.  But the client's listening port for reverse connections 
>> defaults to 5500.  "-vnc :-400,rev" is clearly insane, but it seems strange 
>> for an option like ",rev" to change the meaning of the port field.
>>     
>
> Yes that is a valid point. It is a little unfortunate we switched to using
> display num instead of port num for the current VNC code. Having a syntax
> which makes people use negative display nums for reverse connections would
> suck. So reluctantly I think your original proposal may actually be better.
>   

Yet this is the syntax we use for normal connections.  I don't see why 
the asymmetry is okay for reverse connections.

Regard,

Anthony Liguori

> Dan.
>