From: Ben Warren <biggerbadderben@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] resend#3 [PATCH 6/8] ColdFire: Add MCF547x_8x FEC driver
Date: Thu, 17 Jan 2008 13:36:04 -0500 [thread overview]
Message-ID: <478FA014.1080200@gmail.com> (raw)
In-Reply-To: <4791E710007FEB4BBF83775D787F462F05E89588@az33exm22.fsl.freescale.net>
Liew Tsi Chung wrote:
> Ben,
>
>
>> Right, so there's no need to mention them in C code. Less is
>> more, as they say.
>>
> Agree.
>
> So, everything ok now?
>
>
I haven't seen the patch that removes the prototypes, but it's quite
possible I looked past it. In a previous e-mail I added a
'signed-off-by' that John Rigby can add to the patch commit. I consider
this to be a Coldfire patch because it's dependent on other patches in
the series and I have no way of testing it.
I hope that's OK.
regards,
Ben
> Regards,
> TsiChung
>
> -----Original Message-----
> From: Ben Warren [mailto:biggerbadderben at gmail.com]
> Sent: Thursday, January 17, 2008 12:27 PM
> To: Liew Tsi Chung
> Cc: U-Boot-Users; Wolfgang Denx; Rigby John
> Subject: Re: [U-Boot-Users] resend#3 [PATCH 6/8] ColdFire: Add
> MCF547x_8x FEC driver
>
> Liew Tsi Chung wrote:
>
>> Ben,
>>
>> The prototypes have place in include/asm-m68k/fsl_mcdmafec.h.
>>
>> Regards,
>> TsiChung
>>
>>
>>
> Right, so there's no need to mention them in C code. Less is more, as
> they say.
>
> regards,
> Ben
>
>
prev parent reply other threads:[~2008-01-17 18:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-16 23:24 [U-Boot-Users] resend#3 [PATCH 6/8] ColdFire: Add MCF547x_8x FEC driver Tsi-Chung Liew
2008-01-17 2:33 ` Ben Warren
2008-01-17 17:49 ` Liew Tsi Chung
2008-01-17 18:27 ` Ben Warren
2008-01-17 18:32 ` Liew Tsi Chung
2008-01-17 18:36 ` Ben Warren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=478FA014.1080200@gmail.com \
--to=biggerbadderben@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.