From: Paolo Bonzini <bonzini@gnu.org>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>,
Git Mailing List <git@vger.kernel.org>
Subject: Re: [PATCH] git-commit: add a prepare-commit-msg hook
Date: Fri, 18 Jan 2008 17:37:35 +0100 [thread overview]
Message-ID: <4790D5CF.8000602@gnu.org> (raw)
In-Reply-To: <alpine.LSU.1.00.0801181605020.5731@racer.site>
> In the message hook, just grep if the template was already added. If it
> was, just return. If it was not, add it.
Ah, so you want me to always type ":q!" to exit and unnecessarily
complicate the commit-msg hook. Cunning, but no, thanks.
I'll make an example. This is my prepare-commit-msg hook:
diff_collect_changelog ()
{
git diff "$@" -- \
`git diff "$@" --name-status -r | \
awk '/ChangeLog/ { print substr ($0, 3) }'` | sed -n \
-e '/^@@/,/^+/ {' \
-e ' s/^ //p' \
-e ' t' \
-e '}' \
-e '/^diff/,/^@@/ {' \
-e ' s/^diff --git a\/\(.*\)\/ChangeLog[^ ]* b\/.*/\1:/p' \
-e ' tdummy' \
-e ' :dummy' \
-e ' d' \
-e '}' \
-e 's/^+//p' \
-e 't'
}
diff_collect_changelog --cached > /tmp/foo$$
cat "$GIT_COMMIT_MSG" >> /tmp/foo$$ && \
mv /tmp/foo$$ "$GIT_COMMIT_MSG"
rm -f /tmp/foo$$
or something like that. The alternative I see would be to start the vi
editing session with "!!make_changelog --cached". So I thought about
having an hook that runs the command for me. Do you have better ideas?
Paolo
next prev parent reply other threads:[~2008-01-18 16:38 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-18 14:51 [PATCH] git-commit: add a prepare-commit-msg hook Paolo Bonzini
2008-01-18 15:47 ` Johannes Schindelin
2008-01-18 15:51 ` Paolo Bonzini
2008-01-18 16:06 ` Johannes Schindelin
2008-01-18 16:37 ` Paolo Bonzini [this message]
2008-01-18 18:06 ` Johannes Schindelin
2008-01-18 18:51 ` Paolo Bonzini
2008-01-18 19:01 ` Benoit Sigoure
2008-01-18 19:05 ` Alex Riesen
2008-01-18 19:46 ` Paolo Bonzini
2008-01-18 21:08 ` Alex Riesen
2008-01-18 22:05 ` Junio C Hamano
2008-01-19 9:32 ` Paolo Bonzini
2008-01-19 11:20 ` Johannes Schindelin
2008-01-19 15:41 ` Benoit Sigoure
2008-01-19 16:04 ` Paolo Bonzini
2008-01-20 22:28 ` Junio C Hamano
2008-01-21 6:16 ` Paolo Bonzini
2008-01-21 11:04 ` Johannes Schindelin
2008-01-21 12:14 ` Paolo Bonzini
2008-01-21 12:46 ` Johannes Schindelin
2008-01-21 12:59 ` Paolo Bonzini
2008-01-21 22:44 ` Junio C Hamano
-- strict thread matches above, loose matches on Subject: below --
2008-01-21 14:27 Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4790D5CF.8000602@gnu.org \
--to=bonzini@gnu.org \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.