All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jochen Friedrich <jochen@scram.de>
To: Scott Wood <scottwood@freescale.com>
Cc: linuxppc-dev@ozlabs.org, Stephen Rothwell <sfr@canb.auug.org.au>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH/RFCv2] [POWERPC] Add support for freescale watchdog to CPM serial driver.
Date: Fri, 18 Jan 2008 18:33:19 +0100	[thread overview]
Message-ID: <4790E2DF.90806@scram.de> (raw)
In-Reply-To: <4790DC33.2070104@freescale.com>

Scott Wood schrieb:

>> +void watchdog_poke(void)
>> +{
>> +    if (wdt) {
>> +        out_be16(&wdt->swsrr, 0x556c);
>> +        out_be16(&wdt->swsrr, 0xaa39);
>> +    }
>> +}
> 
> This should be a function pointer, to allow for other watchdog types.

Thanks for the comments. Stephen Rothwell also asked if the filename watchdog.c is too generic.
I think the pq watchdog is easy enough to keep it in the generic watchdog.c file, but the
function pointer definitely is the way to go. I'll resubmit.

Thanks,
Jochen

WARNING: multiple messages have this Message-ID (diff)
From: Jochen Friedrich <jochen@scram.de>
To: Scott Wood <scottwood@freescale.com>
Cc: linuxppc-dev@ozlabs.org, linux-kernel@vger.kernel.org,
	Vitaly Bordug <vitb@kernel.crashing.org>,
	Stephen Rothwell <sfr@canb.auug.org.au>
Subject: Re: [PATCH/RFCv2] [POWERPC] Add support for freescale watchdog to CPM serial driver.
Date: Fri, 18 Jan 2008 18:33:19 +0100	[thread overview]
Message-ID: <4790E2DF.90806@scram.de> (raw)
In-Reply-To: <4790DC33.2070104@freescale.com>

Scott Wood schrieb:

>> +void watchdog_poke(void)
>> +{
>> +    if (wdt) {
>> +        out_be16(&wdt->swsrr, 0x556c);
>> +        out_be16(&wdt->swsrr, 0xaa39);
>> +    }
>> +}
> 
> This should be a function pointer, to allow for other watchdog types.

Thanks for the comments. Stephen Rothwell also asked if the filename watchdog.c is too generic.
I think the pq watchdog is easy enough to keep it in the generic watchdog.c file, but the
function pointer definitely is the way to go. I'll resubmit.

Thanks,
Jochen

  reply	other threads:[~2008-01-18 17:32 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-17 12:32 [PATCH/RFCv2] [POWERPC] Add support for freescale watchdog to CPM serial driver Jochen Friedrich
2008-01-17 12:32 ` Jochen Friedrich
2008-01-18  0:38 ` Stephen Rothwell
2008-01-18  0:38   ` Stephen Rothwell
2008-01-18 17:04 ` Scott Wood
2008-01-18 17:04   ` Scott Wood
2008-01-18 17:33   ` Jochen Friedrich [this message]
2008-01-18 17:33     ` Jochen Friedrich
2008-01-18 18:39 ` Alan Cox
2008-01-18 18:39   ` Alan Cox
2008-01-18 18:47   ` Jochen Friedrich
2008-01-18 18:47     ` Jochen Friedrich
2008-01-18 20:40     ` Alan Cox
2008-01-18 20:40       ` Alan Cox
2008-01-18 21:51       ` Kumar Gala
2008-01-18 21:51         ` Kumar Gala
2008-01-18 21:54         ` Scott Wood
2008-01-18 21:54           ` Scott Wood
2008-01-18 21:56         ` Jochen Friedrich
2008-01-18 21:56           ` Jochen Friedrich
2008-01-18 22:08           ` Kumar Gala
2008-01-18 22:08             ` Kumar Gala

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4790E2DF.90806@scram.de \
    --to=jochen@scram.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=scottwood@freescale.com \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.