From: "H. Peter Anvin" <hpa@zytor.com>
To: Harvey Harrison <harvey.harrison@gmail.com>
Cc: Ingo Molnar <mingo@elte.hu>, Thomas Gleixner <tglx@linutronix.de>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCHv2] x86: Use v8086_mode helper, trivial unification
Date: Fri, 18 Jan 2008 14:02:23 -0500 [thread overview]
Message-ID: <4790F7BF.2070304@zytor.com> (raw)
In-Reply-To: <1200683074.5724.137.camel@brick>
Harvey Harrison wrote:
> On Fri, 2008-01-18 at 16:00 +0100, Ingo Molnar wrote:
>>>> + /*
>>>> + * Did it hit the DOS screen memory VA from vm86 mode?
>>>> + */
>>>> + if (v8086_mode(regs)) {
>>>> + unsigned long bit = (address - 0xA0000) >> PAGE_SHIFT;
>>>> + if (bit < 32)
>>>> + tsk->thread.screen_bitmap |= 1 << bit;
>>>> + }
>> this does not build on 64-bit, because screen_bitmap is 32-bit only - so
>> i had to pull the patch. I suspect a small #ifdef section would look
>> better here?
>>
>
> My original patch had the ifdef, you can grab that one.
>
Me bad, I should have been less definite in my reply.
-hpa
prev parent reply other threads:[~2008-01-18 19:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-18 0:25 [PATCHv2] x86: Use v8086_mode helper, trivial unification Harvey Harrison
2008-01-18 9:12 ` Ingo Molnar
2008-01-18 9:22 ` Harvey Harrison
2008-01-18 15:00 ` Ingo Molnar
2008-01-18 19:04 ` Harvey Harrison
2008-01-18 19:02 ` H. Peter Anvin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4790F7BF.2070304@zytor.com \
--to=hpa@zytor.com \
--cc=harvey.harrison@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.