All of lore.kernel.org
 help / color / mirror / Atom feed
From: Patrick McHardy <kaber@trash.net>
To: Jan Engelhardt <jengelh@computergmbh.de>
Cc: Netfilter Developer Mailing List <netfilter-devel@vger.kernel.org>
Subject: Re: [PATCH 1/2] [NETFILTER]: xt_TCPMSS: Consider incoming device's MTU in clamp-to-pmtu
Date: Sun, 20 Jan 2008 14:48:23 +0100	[thread overview]
Message-ID: <47935127.30902@trash.net> (raw)
In-Reply-To: <Pine.LNX.4.64.0801201318040.14598@fbirervta.pbzchgretzou.qr>

Jan Engelhardt wrote:
> commit 1ed78bbf75455dfe77a028f2da2f351cff4028f2
> Author: Jan Engelhardt <jengelh@computergmbh.de>
> Date:   Sun Jan 20 13:13:33 2008 +0100
> 
>     [NETFILTER]: xt_TCPMSS: Consider incoming device's MTU in clamp-to-pmtu
>     
>     The TCPMSS target in Xtables should consider the MTU of the input
>     device on forwarded packets as part of the path MTU.
>     
>     Point in case: IN=ppp0, OUT=eth0. MSS set to 1460 in spite of MTU of
>     ppp0 being 1392.


> -				   sizeof(*ipv6h) + sizeof(struct tcphdr));
> +	ret = tcpmss_mangle_packet(skb, targinfo, (in == NULL) ? ~0U : in->mtu,
> +	      tcphoff, sizeof(*ipv6h) + sizeof(struct tcphdr));


This is slightly better than what we currently have, but it should
actually use the MTU from the dst_entry for the reverse direction.
I've tried adding this not too long ago and ran into some problems,
but I can't remember the exact details.

  parent reply	other threads:[~2008-01-20 13:49 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-20 12:18 [PATCH 1/2] [NETFILTER]: xt_TCPMSS: Consider incoming device's MTU in clamp-to-pmtu Jan Engelhardt
2008-01-20 12:19 ` [PATCH 2/2] [NETFILTER]: xt_owner: allow matching UID/GID ranges Jan Engelhardt
2008-01-20 13:50   ` Patrick McHardy
2008-01-20 18:03     ` Jan Engelhardt
2008-01-24  7:57   ` Patrick McHardy
2008-01-20 13:48 ` Patrick McHardy [this message]
2008-01-22 21:10   ` [PATCH 1/2] [NETFILTER]: xt_TCPMSS: Consider incoming device's MTU in clamp-to-pmtu Jan Engelhardt
2008-01-23 14:20     ` Patrick McHardy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47935127.30902@trash.net \
    --to=kaber@trash.net \
    --cc=jengelh@computergmbh.de \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.