From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Roger C. Soares" Subject: Re: [EGIT PATCH] Removed Auto-generated TODOs, they don't specify something to do. Date: Sun, 20 Jan 2008 23:27:36 -0200 Message-ID: <4793F508.1000503@intelinet.com.br> References: <1200860941-6922-1-git-send-email-rogersoares@intelinet.com.br> <200801202207.28128.robin.rosenberg.lists@dewire.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: git@vger.kernel.org, "Shawn O. Pearce" To: Robin Rosenberg X-From: git-owner@vger.kernel.org Mon Jan 21 02:28:48 2008 Return-path: Envelope-to: gcvg-git-2@gmane.org Received: from vger.kernel.org ([209.132.176.167]) by lo.gmane.org with esmtp (Exim 4.50) id 1JGlSx-0000oh-7K for gcvg-git-2@gmane.org; Mon, 21 Jan 2008 02:28:47 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756463AbYAUB2R (ORCPT ); Sun, 20 Jan 2008 20:28:17 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756455AbYAUB2R (ORCPT ); Sun, 20 Jan 2008 20:28:17 -0500 Received: from cvxbsd.convex.com.br ([200.152.177.10]:1150 "HELO cvxbsd.convex.com.br" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1756435AbYAUB2R (ORCPT ); Sun, 20 Jan 2008 20:28:17 -0500 Received: (qmail 70178 invoked by uid 0); 20 Jan 2008 23:31:20 -0200 Received: from rogersoares@intelinet.com.br by cvxbsd.convex.com.br by uid 82 with qmail-scanner-1.20rc3 (uvscan: v4.3.20/v4817. Clear:RC:1:. Processed in 0.241398 secs); 21 Jan 2008 01:31:20 -0000 Received: from unknown (HELO ?200.152.180.33?) (200.152.180.33) by cvxbsd.convex.com.br with SMTP; 21 Jan 2008 01:31:20 -0000 User-Agent: Thunderbird 1.5.0.12 (X11/20071129) In-Reply-To: <200801202207.28128.robin.rosenberg.lists@dewire.com> Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: Robin Rosenberg escreveu: > Unfortunately it is not that easy. Most of the TODO's are left there > intentionally. They signal work to do, i.e. proper error handling. At minimum > we should use Eclipse's error logging. For JGit we could encapsulate it a > little as we don't have direct access to the Eclipse runtime there. > Ok. > BTW JGit is currently mostly GPL'ed. I want to have your permission to > relicense anything you contribute there under the EPL (Eclipse Public > License), just in case we go down that road and make it an Eclipse project. > Sure, permission granted. > You put a finger on a sore point. We'll see if I can find a way to replace > those TODO's with something sensible. > > Also, please Cc: directly for egit patches. Shawn, want Cc: to? > > -- robin > Ok. []s, Roger.