From: Philip Craig <philipc@snapgear.com>
To: Patrick McHardy <kaber@trash.net>
Cc: tgraf@suug.ch, netfilter-devel@vger.kernel.org
Subject: Re: [LIBNL 07/09]: Split up nfnetlink_log into log and msg objects
Date: Mon, 21 Jan 2008 18:05:40 +1000 [thread overview]
Message-ID: <47945254.5000008@snapgear.com> (raw)
In-Reply-To: <20080118165524.13385.49205.sendpatchset@localhost.localdomain>
Patrick McHardy wrote:
> commit c566db4405200994482d36fac45089aba4e2360a
> Author: Patrick McHardy <kaber@trash.net>
> Date: Fri Jan 18 17:52:41 2008 +0100
>
> [LIBNL]: Split up nfnetlink_log into log and msg objects
>
> Split the nfnetlink_log code into two seperate objects, "netfilter/log"
> to represent logging instances and "netfilter/log_msg" to represent
> log messages. Also perform some function name unification for consistency
> with other libnl object types, mainly renaming nfnl_log_build_*_msg
> to nfnl_log_build_*_request.
>
> This changes the API in an incompatible way, but since this feature is
> new and the libnl netfilter headers haven't been installed so far,
> there shouldn't be any users affected by this.
>
> Signed-off-by: Patrick McHardy <kaber@trash.net>
Definitely an improvement, thanks. The pf bind/unbind are still handled
differently, but I guess they are too simple to warrant it and will
never get more attributes.
I hadn't noticed the missing headers because my cross compile
environment has its own custom install target.
next prev parent reply other threads:[~2008-01-21 7:59 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-18 16:55 [LIBNL 00/09]: Netfilter update + minor fixes Patrick McHardy
2008-01-18 16:55 ` [LIBNL 01/09]: Add if_vlan.h Patrick McHardy
2008-02-07 11:50 ` Thomas Graf
2008-01-18 16:55 ` [LIBNL 02/09]: Fix minor memleaks on exit Patrick McHardy
2008-02-07 11:52 ` Thomas Graf
2008-01-18 16:55 ` [LIBNL 03/09]: Generic netfilter stuff Patrick McHardy
2008-02-07 11:54 ` Thomas Graf
2008-01-18 16:55 ` [LIBNL 04/09]: Add nfnetlink_queue support Patrick McHardy
2008-02-07 12:00 ` Thomas Graf
2008-01-18 16:55 ` [LIBNL 05/09]: nfnetlink_log: only set hwproto if not zero Patrick McHardy
2008-02-07 12:01 ` Thomas Graf
2008-01-18 16:55 ` [LIBNL 06/09]: nfnetlink_log: support NUFLA_GID attribute Patrick McHardy
2008-02-07 12:03 ` Thomas Graf
2008-01-18 16:55 ` [LIBNL 07/09]: Split up nfnetlink_log into log and msg objects Patrick McHardy
2008-01-21 8:05 ` Philip Craig [this message]
2008-01-21 9:45 ` Patrick McHardy
2008-02-07 12:11 ` Thomas Graf
2008-01-18 16:55 ` [LIBNL 08/09]: Support conntrack add/delete/query requests Patrick McHardy
2008-01-21 8:39 ` Philip Craig
2008-01-21 9:46 ` Patrick McHardy
2008-01-21 10:53 ` Philip Craig
2008-01-21 10:55 ` Patrick McHardy
2008-02-07 12:14 ` Thomas Graf
2008-02-19 12:32 ` Patrick McHardy
2008-01-18 16:56 ` [LIBNL 09/09]: Install netfilter headers Patrick McHardy
2008-02-07 12:16 ` Thomas Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47945254.5000008@snapgear.com \
--to=philipc@snapgear.com \
--cc=kaber@trash.net \
--cc=netfilter-devel@vger.kernel.org \
--cc=tgraf@suug.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.