All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jan Kiszka <jan.kiszka@domain.hid>
To: Philippe Gerum <rpm@xenomai.org>
Cc: Xenomai-core@domain.hid
Subject: [Xenomai-core] Patch selection by prepare-kernel.sh (again)
Date: Mon, 21 Jan 2008 19:01:27 +0100	[thread overview]
Message-ID: <4794DDF7.9070009@domain.hid> (raw)

Philippe,

what was the idea behind commit #3256 [1]? It breaks the original
behavior of selection adeos-ipipe-2.6.23-... in the presence of 2.6.23.x
- and leaves a bad first impression for beginners (I received such a
notice here...). Was this for the special case
adeos-ipipe-2.6.20.21-i386-1.12-02.patch? But I think the common case
should take precedence over this corner case here. Unless there are more
issues with the original version, I would vote for restoring it.

Alternatively, we could add a safety belt by trying to apply the patch
with --dry-run first and only continue if this works out without
failures. Can hack this up if it's acceptable.

Jan

[1]http://svn.gna.org/viewcvs/xenomai/trunk/scripts/prepare-kernel.sh?rev=3257&view=diff&r1=3257&r2=3256&p1=trunk/scripts/prepare-kernel.sh&p2=/trunk/scripts/prepare-kernel.sh

-- 
Siemens AG, Corporate Technology, CT SE 2
Corporate Competence Center Embedded Linux


             reply	other threads:[~2008-01-21 18:01 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-21 18:01 Jan Kiszka [this message]
2008-01-21 18:32 ` [Xenomai-core] Patch selection by prepare-kernel.sh (again) Jan Kiszka
2008-01-21 18:48   ` Jan Kiszka
2008-01-22 16:23     ` Philippe Gerum
2008-01-22 16:43       ` Gilles Chanteperdrix

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4794DDF7.9070009@domain.hid \
    --to=jan.kiszka@domain.hid \
    --cc=Xenomai-core@domain.hid \
    --cc=rpm@xenomai.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.