From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christian Ehrhardt Date: Tue, 22 Jan 2008 12:16:38 +0000 Subject: Re: [kvm-ppc-devel] [PATCH] PowerPC snapshot, Message-Id: <4795DEA6.4090300@linux.vnet.ibm.com> List-Id: References: <42DFA526FC41B1429CE7279EF83C6BDCC9B968@pdsmsx415.ccr.corp.intel.com> In-Reply-To: <42DFA526FC41B1429CE7279EF83C6BDCC9B968@pdsmsx415.ccr.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable To: kvm-ppc@vger.kernel.org Hi Zhang Wei, this is a known issue but avtually it should be solved in the snapshot. It = is already discussed on kvm-devel because it is a common issue (ppc & s390 = & ?). You might want to look at the threads "[kvm-ppc-devel] [PATCH 1 of 2] Defin= e and use CONFIG_KVM_HAS_PIO so that we don't need pio_data in kvm_arch_vcp= u" and the old one "[kvm-ppc-devel] [PATCH] RFC: Use CONFIG_HAS_IOPORT arou= nd vcpu->pio_data".=20 So it is on the way to upstream anyway and you might just want to use Holli= s last patch to that out of the first mail thread I listed above until it i= s upstream (this helps you however Avi eventually implements it). --=20 Gr=FCsse / regards,=20 Christian Ehrhardt IBM Linux Technology Center, Open Virtualization Zhang Wei wrote: > Hi, Hollis, >=20 > A make error is here: > arch/powerpc/kvm/../../../virt/kvm/kvm_main.c: In function > 'kvm_vcpu_fault': > arch/powerpc/kvm/../../../virt/kvm/kvm_main.c:681: error: 'struct > kvm_vcpu_arch' has no member named 'pio_data'=20 >=20 > I have to add pio_data to kvm_vcpu_arch structure to pass the kvm_main.c > compile. >=20 > diff --git a/include/asm-powerpc/kvm_host.h > b/include/asm-powerpc/kvm_host.h > index f3bb913..ef57aec 100644 > --- a/include/asm-powerpc/kvm_host.h > +++ b/include/asm-powerpc/kvm_host.h > @@ -125,6 +125,8 @@ struct kvm_vcpu_arch { >=20 > struct timer_list dec_timer; > int pending_dec; > + > + void *pio_data; > }; >=20 > struct kvm_tlb { >=20 > Did you get that error? >=20 > Cheers! > Wei. >> -----Original Message----- >> From: kvm-ppc-devel-bounces@lists.sourceforge.net=20 >> [mailto:kvm-ppc-devel-bounces@lists.sourceforge.net] On=20 >> Behalf Of Hollis Blanchard >> Sent: Saturday, January 19, 2008 2:08 AM >> To: kvm-ppc-devel >> Subject: Re: [kvm-ppc-devel] [PATCH] PowerPC=20 >> snapshot,integrated with upstream >> >> On Thu, 2008-01-17 at 00:33 -0600, Hollis Blanchard wrote: >>> There are still a few things we're debugging, but a few=20 >> people expressed >>> interest so I'm sending out a snapshot now. >>> >>> We will be posting qemu patches in the near future as well,=20 >> just as soon >>> as we've beaten it into submission. Linux+Qemu is what doesn't work >>> today. For now this code seems to be working fine with the=20 >> testcases in >>> the kvm-userspace/user directory. >> OK, this is the fixed patch that can run an unmodified Linux guest. In >> addition to some qemu changes, I had to fix "mtdcr" behavior so the PC >> would actually advance past the instruction, and also create a TLB >> mapping to cover the UART (which Linux expects u-boot has left around, >> as specified in the device tree). >> >> We will need to work on getting qemu patches into an emailable state, >> since the kvmctl stuff in kvm-userspace, at least in its current form, >> can't run Linux. Since we still don't do any IO (or interrupts!), UART >> MMIO and SDRAM controller DCR emulation is pretty much the only device >> emulation necessary at this point. >> >> >> >> PowerPC 440 KVM implementation. >> >> Signed-off-by: Hollis Blanchard >> [...] ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ _______________________________________________ kvm-ppc-devel mailing list kvm-ppc-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/kvm-ppc-devel