From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755574AbYAVOdU (ORCPT ); Tue, 22 Jan 2008 09:33:20 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751890AbYAVOdK (ORCPT ); Tue, 22 Jan 2008 09:33:10 -0500 Received: from bzq-179-150-194.static.bezeqint.net ([212.179.150.194]:40682 "EHLO il.qumranet.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751365AbYAVOdJ (ORCPT ); Tue, 22 Jan 2008 09:33:09 -0500 X-Greylist: delayed 1232 seconds by postgrey-1.27 at vger.kernel.org; Tue, 22 Jan 2008 09:33:09 EST Message-ID: <4795F9D2.1050503@qumranet.com> Date: Tue, 22 Jan 2008 16:12:34 +0200 From: Avi Kivity User-Agent: Thunderbird 2.0.0.9 (X11/20071115) MIME-Version: 1.0 To: Andrea Arcangeli CC: Izik Eidus , Andrew Morton , Nick Piggin , kvm-devel@lists.sourceforge.net, Benjamin Herrenschmidt , steiner@sgi.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, daniel.blueman@quadrics.com, holt@sgi.com, Hugh Dickins , clameter@sgi.com Subject: Re: [kvm-devel] [PATCH] mmu notifiers #v3 References: <20080113162418.GE8736@v2.random> <20080116124256.44033d48@bree.surriel.com> <478E4356.7030303@qumranet.com> <20080117162302.GI7170@v2.random> <478F9C9C.7070500@qumranet.com> <20080117193252.GC24131@v2.random> <20080121125204.GJ6970@v2.random> In-Reply-To: <20080121125204.GJ6970@v2.random> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Andrea Arcangeli wrote: > diff --git a/include/asm-generic/pgtable.h b/include/asm-generic/pgtable.h > --- a/include/asm-generic/pgtable.h > +++ b/include/asm-generic/pgtable.h > @@ -44,8 +44,10 @@ > ({ \ > int __young; \ > __young = ptep_test_and_clear_young(__vma, __address, __ptep); \ > - if (__young) \ > + if (__young) { \ > flush_tlb_page(__vma, __address); \ > + mmu_notifier(age_page, (__vma)->vm_mm, __address); \ > + } \ > __young; \ > }) > I think that unconditionally doing __young |= mmu_notifier(test_and_clear_young, ...); allows hardware with accessed bits more control over what is going on. -- error compiling committee.c: too many arguments to function From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] mmu notifiers #v3 Date: Tue, 22 Jan 2008 16:12:34 +0200 Message-ID: <4795F9D2.1050503@qumranet.com> References: <20080113162418.GE8736@v2.random> <20080116124256.44033d48@bree.surriel.com> <478E4356.7030303@qumranet.com> <20080117162302.GI7170@v2.random> <478F9C9C.7070500@qumranet.com> <20080117193252.GC24131@v2.random> <20080121125204.GJ6970@v2.random> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: Andrew Morton , Nick Piggin , linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org, Benjamin Herrenschmidt , steiner-sJ/iWh9BUns@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, daniel.blueman-xqY44rlHlBpWk0Htik3J/w@public.gmane.org, holt-sJ/iWh9BUns@public.gmane.org, Hugh Dickins , clameter-sJ/iWh9BUns@public.gmane.org To: Andrea Arcangeli Return-path: In-Reply-To: <20080121125204.GJ6970-lysg2Xt5kKMAvxtiuMwx3w@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org Andrea Arcangeli wrote: > diff --git a/include/asm-generic/pgtable.h b/include/asm-generic/pgtable.h > --- a/include/asm-generic/pgtable.h > +++ b/include/asm-generic/pgtable.h > @@ -44,8 +44,10 @@ > ({ \ > int __young; \ > __young = ptep_test_and_clear_young(__vma, __address, __ptep); \ > - if (__young) \ > + if (__young) { \ > flush_tlb_page(__vma, __address); \ > + mmu_notifier(age_page, (__vma)->vm_mm, __address); \ > + } \ > __young; \ > }) > I think that unconditionally doing __young |= mmu_notifier(test_and_clear_young, ...); allows hardware with accessed bits more control over what is going on. -- error compiling committee.c: too many arguments to function ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ From mboxrd@z Thu Jan 1 00:00:00 1970 Message-ID: <4795F9D2.1050503@qumranet.com> Date: Tue, 22 Jan 2008 16:12:34 +0200 From: Avi Kivity MIME-Version: 1.0 Subject: Re: [kvm-devel] [PATCH] mmu notifiers #v3 References: <20080113162418.GE8736@v2.random> <20080116124256.44033d48@bree.surriel.com> <478E4356.7030303@qumranet.com> <20080117162302.GI7170@v2.random> <478F9C9C.7070500@qumranet.com> <20080117193252.GC24131@v2.random> <20080121125204.GJ6970@v2.random> In-Reply-To: <20080121125204.GJ6970@v2.random> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org Return-Path: To: Andrea Arcangeli Cc: Izik Eidus , Andrew Morton , Nick Piggin , kvm-devel@lists.sourceforge.net, Benjamin Herrenschmidt , steiner@sgi.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, daniel.blueman@quadrics.com, holt@sgi.com, Hugh Dickins , clameter@sgi.com List-ID: Andrea Arcangeli wrote: > diff --git a/include/asm-generic/pgtable.h b/include/asm-generic/pgtable.h > --- a/include/asm-generic/pgtable.h > +++ b/include/asm-generic/pgtable.h > @@ -44,8 +44,10 @@ > ({ \ > int __young; \ > __young = ptep_test_and_clear_young(__vma, __address, __ptep); \ > - if (__young) \ > + if (__young) { \ > flush_tlb_page(__vma, __address); \ > + mmu_notifier(age_page, (__vma)->vm_mm, __address); \ > + } \ > __young; \ > }) > I think that unconditionally doing __young |= mmu_notifier(test_and_clear_young, ...); allows hardware with accessed bits more control over what is going on. -- error compiling committee.c: too many arguments to function -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org