All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Bruce Rogers" <BROGERS@novell.com>
To: Rik van Riel <riel@redhat.com>
Cc: dshaks@redhat.com, bmarson@redhat.com, xen-devel@lists.xensource.com
Subject: Re: [PATCH] respin of mprotect performance patch
Date: Tue, 22 Jan 2008 14:51:00 -0700	[thread overview]
Message-ID: <47960334.092E.0048.1@novell.com> (raw)
In-Reply-To: <20080122135534.1225627e@cuia.boston.redhat.com>

Your results are quite different from what I've seen. But then again I've been doing slightly different scaling tests, and of course the hardware is different.

In the original problem report we received from SAP, the # of cpus was varied while running their test which runs 3 cpuload streams on each cpu.  I've continued down that path since it shows a steady degradation as more cpus are added.  I've not played with varying the number of cpuload streams in my testing.
Other than that, it sounds like we are running the same SAP test (cpu_load.sh).

Here's what I've seen (numbers are the throughput per cpu, test assigns 3 streams per cpu, test was run in Dom0, as it was in the SAP problem report):
#cpus      native    with patch      without patch
    1         9434       8264                6095
    2         9884       8227                4530
    3         9790       8008                2962
    4         9392       7531                1801
<intervening cpu counts not test, trend seemed obvious>
    8         6507       5870                 669

So as you can see the performance degradation I am seeing is quite marked, and the benefit of the patch quite consistent and obviously beneficial.
The machine I used is a 8 processor  (4 dual core AMD Opteron 8218 CPUs, ea. w/ 1MB L2 Cache) HP Proliant Server with 16GB memory.
I do wish I had been able to do testing with more than 1 machine; perhaps that would have provided better insights into the performance problem.  Out lab is in a state of flux right now as we're moving floors and I hence probably won't be able to do a comparative run on other hardware very soon.

I believe SAP is doing some broad based testing of their own which may help identify how much the hardware has to do with the performance of this test.

What results do you get with native (non-smp) on that same hardware? Have you done runs on other hardware and seen consistent results?

- Bruce

>>> On 1/22/2008 at 11:55 AM, in message
<20080122135534.1225627e@cuia.boston.redhat.com>, Rik van Riel
<riel@redhat.com> wrote:
> On Mon, 21 Jan 2008 10:41:59 -0500
> Rik van Riel <riel@redhat.com> wrote:
> 
>> I tested a quick backport of these patches to XEN 3.1.2 and
>> kernel 2.6.18.
>> 
>> Unfortunately, performance and scalability do not seem to
>> have improved with these patches,
> 
> OK, it turned out the guys with the SAP mprotect benchmark program
> made the mistake of only upgrading the dom0 kernel and not the guest.
> 
> With both dom0 and guest, mprotect performance has improved slightly
> on our dual cpu, dual core (4 cores total) Intel x86-64 test system:
> 
> CPULOAD    WITH     
> STREAMS    PATCH     STANDARD
> 1        13108.77    11188.68
> 2        13135.63    11146.06
> 3        10522.82     9910.10
> 4         8622.47     9399.66
> 6         6571.49     7078.12
> 8         5141.23     5389.15
> 10        4514.37     4372.87
> 12        4226.79     3802.98
> 
> So we have about a 10-15% performance improvement at some numbers of
> streams, and a performance decrease at some other numbers of streams.
> Over-all performance impact of the patch seems to be about even :(
> 
> I wonder if this is just an artifact of the system we tested this on,
> or if it can be seen across multiple systems.
> 
> Bruce, what kinds of systems have you tested the patch on and what
> kind of performance numbers are you seeing?

  reply	other threads:[~2008-01-22 21:51 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-08  1:05 [PATCH] respin of mprotect performance patch Bruce Rogers
2008-01-10 15:52 ` Keir Fraser
2008-01-10 17:13   ` Bruce Rogers
2008-01-10 17:42     ` Keir Fraser
2008-01-12 11:47 ` Keir Fraser
2008-01-13  3:08   ` Bruce Rogers
2008-01-13  9:21     ` Keir Fraser
2008-01-21 15:41     ` Rik van Riel
2008-01-22 18:55       ` Rik van Riel
2008-01-22 21:51         ` Bruce Rogers [this message]
2008-01-28 17:53           ` Hannes Kuehnemund
2008-01-28 20:00             ` Rik van Riel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47960334.092E.0048.1@novell.com \
    --to=brogers@novell.com \
    --cc=bmarson@redhat.com \
    --cc=dshaks@redhat.com \
    --cc=riel@redhat.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.