From: Patrick McHardy <kaber@trash.net>
To: Alexey Dobriyan <adobriyan@sw.ru>
Cc: netfilter-devel@vger.kernel.org, netdev@vger.kernel.org,
devel@openvz.org
Subject: Re: [PATCH 3/5] netns netfilter: return new table from {arp,ip,ip6}t_register_table()
Date: Tue, 22 Jan 2008 17:57:16 +0100 [thread overview]
Message-ID: <4796206C.4060100@trash.net> (raw)
In-Reply-To: <20080121145357.GH27615@localhost.sw.ru>
Alexey Dobriyan wrote:
> Typical table module registers xt_table structure (i.e. packet_filter)
> and link it to list during it. We can't use one template for it because
> corresponding list_head will become corrupted. We also can't unregister
> with template because it wasn't changed at all and thus doesn't know in
> which list it is.
>
> So, we duplicate template at the very first step of table registration.
> Table modules will save it for use during unregistration time and actual
> filtering.
>
> Do it at once to not screw bisection.
Applied, thanks.
> P.S.: renaming i.e. packet_filter => __packet_filter is temporary until
> full netnsization of table modules is done.
It seems this could have been avoided by ordering the patches
differently (I probably would also have done 4/5 as 1/5).
prev parent reply other threads:[~2008-01-22 16:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-21 14:53 [PATCH 3/5] netns netfilter: return new table from {arp,ip,ip6}t_register_table() Alexey Dobriyan
2008-01-22 16:57 ` Patrick McHardy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4796206C.4060100@trash.net \
--to=kaber@trash.net \
--cc=adobriyan@sw.ru \
--cc=devel@openvz.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.