All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff Garzik <jeff@garzik.org>
To: Sreenivasa Honnur <Sreenivasa.Honnur@neterion.com>
Cc: netdev@vger.kernel.org, support@neterion.com
Subject: Re: [PATCH 2.6.25 1/1]S2io: Multiqueue network device support implementation
Date: Tue, 22 Jan 2008 19:55:11 -0500	[thread overview]
Message-ID: <4796906F.2010503@garzik.org> (raw)
In-Reply-To: <Pine.GSO.4.10.10801221942530.24414-100000@guinness>

Sreenivasa Honnur wrote:
> Multiqueue netwrok device support implementation.
> - Added a loadable parameter "multiq" to enable/disable multiqueue support,
>   by default it is disabled.
> - skb->queue_mapping is not used for queue/fifo selection. FIFO iselection is
>   based on IP-TOS value, 0x0-0xF TOS values are mapped to 8 FIFOs.
> - Added per FIFO flags FIFO_QUEUE_START and FIFO_QUEUE_STOP. Check this flag
>   for starting and stopping netif queue and update the flags accordingly.
> - In tx_intr_handler added a check to ensure that we have free TXDs before wak-
>   ing up the queue.
> - Added helper functions for queue manipulation(start/stop/wakeup) to invoke
>   appropriate netif_ functions.
> - Calling netif_start/stop for link up/down case respectively.
> 
> Signed-off-by: Surjit Reang <surjit.reang@neterion.com>
> Signed-off-by: Sreenivasa Honnur <sreenivasa.honnur@neterion.com>

thanks, at a quick glance, the use of the new multi-queue APIs look ok. 
  I'll give it another in-depth look and merge it.



  reply	other threads:[~2008-01-23  0:55 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-23  0:45 [PATCH 2.6.25 1/1]S2io: Multiqueue network device support implementation Sreenivasa Honnur
2008-01-23  0:55 ` Jeff Garzik [this message]
2008-01-23 10:58 ` Andi Kleen
2008-01-23 20:48   ` Ramkrishna Vepa
2008-01-24  7:25     ` Andi Kleen
2008-01-24  7:30       ` David Miller
2008-01-25  3:19         ` Ramkrishna Vepa
2008-01-25  3:19       ` Ramkrishna Vepa
  -- strict thread matches above, loose matches on Subject: below --
2007-12-26 23:33 Sreenivasa Honnur

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4796906F.2010503@garzik.org \
    --to=jeff@garzik.org \
    --cc=Sreenivasa.Honnur@neterion.com \
    --cc=netdev@vger.kernel.org \
    --cc=support@neterion.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.