Re: [PATCH] ACPI: battery: add sysfs serial number

[Alexey Starikovskiy <astarikovskiy@suse.de>]

maximilian attems wrote:
> got the following question:
> ~/src/hal$ egrep 'voltage_(max|min)_design' -r .
> ./hald/linux/device.c:  if (hal_util_get_int_from_file (path, "voltage_max_design", &voltage_design, 10)) {
> 
> any particular reason the kernel is calling it
> cat /sys/class/power_supply/BAT0/voltage_min_design 
> 14400000
> 
> shall i send in a patch along the line:
> -       case POWER_SUPPLY_PROP_VOLTAGE_MIN_DESIGN:
> +       case POWER_SUPPLY_PROP_VOLTAGE_MAX_DESIGN:
>                 val->intval = battery->design_voltage * 1000;
> 
> or is it hal beeing silly?
> 
On most new batteries design voltage is less than current voltage, thus I've chosen VOLTAGE_MIN_DESIGN.
On older batteries, current voltage may become lower than design, so I think hal should not be very 
strict about how they relate to each other. 

Alex.