From: Daniel J Walsh <dwalsh@redhat.com>
To: Stephen Smalley <sds@tycho.nsa.gov>
Cc: SE Linux <selinux@tycho.nsa.gov>
Subject: Re: Patch to install selinux python with correct permissions.
Date: Wed, 23 Jan 2008 15:04:27 -0500 [thread overview]
Message-ID: <47979DCB.20203@redhat.com> (raw)
In-Reply-To: <1201096319.7025.264.camel@moss-spartans.epoch.ncsc.mil>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Stephen Smalley wrote:
> On Tue, 2008-01-08 at 05:19 -0500, Daniel J Walsh wrote:
>> plain text document attachment (diff)
>> diff --exclude-from=exclude -N -u -r nsalibselinux/src/Makefile libselinux-2.0.46/src/Makefile
>> --- nsalibselinux/src/Makefile 2007-09-26 19:37:45.000000000 -0400
>> +++ libselinux-2.0.46/src/Makefile 2008-01-05 08:19:27.000000000 -0500
>> @@ -77,14 +77,14 @@
>>
>> install: all
>> test -d $(LIBDIR) || install -m 755 -d $(LIBDIR)
>> - install -m 644 $(LIBA) $(LIBDIR)
>
> Why remove the static library from the install target? We still want it
> installable via some target.
>
Yes we should not do this.
>> test -d $(SHLIBDIR) || install -m 755 -d $(SHLIBDIR)
>> install -m 755 $(LIBSO) $(SHLIBDIR)
>> cd $(LIBDIR) && ln -sf ../../`basename $(SHLIBDIR)`/$(LIBSO) $(TARGET)
>>
>> install-pywrap: pywrap
>> test -d $(PYTHONLIBDIR)/site-packages || install -m 755 -d $(PYTHONLIBDIR)/site-packages
>> - install -m 755 $(SWIGFILES) $(PYTHONLIBDIR)/site-packages
>> + install -m 755 $(SWIGSO) $(PYTHONLIBDIR)/site-packages
>> + install -m 644 selinux.py $(PYTHONLIBDIR)/site-packages
>
> So is there much point in keeping SWIGFILES around then? Also used in
> clean: at present, but that's the only remaining use. And presumably
> the same change should happen to libsemanage?
>
I don't think so. I would remove them and spell it out.
>> relabel:
>> /sbin/restorecon $(SHLIBDIR)/$(LIBSO)
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.8 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org
iEYEARECAAYFAkeXncsACgkQrlYvE4MpobOx1wCgrqcLDl4mtY7Yf6biBsbmuLEy
830An2LE/elmxj8/VBZhLV0UxJmmp2Q2
=Z3kZ
-----END PGP SIGNATURE-----
--
This message was distributed to subscribers of the selinux mailing list.
If you no longer wish to subscribe, send mail to majordomo@tycho.nsa.gov with
the words "unsubscribe selinux" without quotes as the message.
prev parent reply other threads:[~2008-01-23 20:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-08 10:19 Patch to install selinux python with correct permissions Daniel J Walsh
2008-01-23 13:51 ` Stephen Smalley
2008-01-23 20:04 ` Daniel J Walsh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47979DCB.20203@redhat.com \
--to=dwalsh@redhat.com \
--cc=sds@tycho.nsa.gov \
--cc=selinux@tycho.nsa.gov \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.