From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [RFC][PATCH 3/5] ksm source code Date: Thu, 24 Jan 2008 11:22:22 +0200 Message-ID: <479858CE.3060704@qumranet.com> References: <4794C477.3090708@qumranet.com> <20080124072432.GQ3627@sequoia.sous-sol.org> <4798554D.1010300@qumranet.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: andrea-atKUWr5tajBWk0Htik3J/w@public.gmane.org, yaniv-atKUWr5tajBWk0Htik3J/w@public.gmane.org, kvm-devel , Chris Wright , linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org To: Izik Eidus Return-path: In-Reply-To: <4798554D.1010300-atKUWr5tajBWk0Htik3J/w@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org Izik Eidus wrote: >> >>> struct ksm *ksm; >>> >> >> static >> >> > > yes Actually the entire contents of 'struct ksm' should be module static variables. -- Any sufficiently difficult bug is indistinguishable from a feature. ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ From mboxrd@z Thu Jan 1 00:00:00 1970 Message-ID: <479858CE.3060704@qumranet.com> Date: Thu, 24 Jan 2008 11:22:22 +0200 From: Avi Kivity MIME-Version: 1.0 Subject: Re: [kvm-devel] [RFC][PATCH 3/5] ksm source code References: <4794C477.3090708@qumranet.com> <20080124072432.GQ3627@sequoia.sous-sol.org> <4798554D.1010300@qumranet.com> In-Reply-To: <4798554D.1010300@qumranet.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org Return-Path: To: Izik Eidus Cc: Chris Wright , kvm-devel , andrea@qumranet.com, dor.laor@qumranet.com, linux-mm@kvack.org, yaniv@qumranet.com List-ID: Izik Eidus wrote: >> >>> struct ksm *ksm; >>> >> >> static >> >> > > yes Actually the entire contents of 'struct ksm' should be module static variables. -- Any sufficiently difficult bug is indistinguishable from a feature. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org