From: Uri Lublin <uril-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
To: Chris Lalancette <clalance-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
Subject: Re: [PATCH]: Make migration handle errors a little better
Date: Thu, 24 Jan 2008 13:01:53 +0200 [thread overview]
Message-ID: <47987021.6010203@qumranet.com> (raw)
In-Reply-To: <4797997A.1050809-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Chris Lalancette wrote:
> All,
> Attached is a fairly simple patch to the migration code to make it handle
> errors better. In particular, if the remote side wasn't set up properly (i.e.
> the memory size didn't match), the migration would fail, but the source host
> didn't actually react properly, so the migration would still be "in-progress".
> This patch fixes up the error checking to properly quit when the remote side
> isn't prepared for whatever reason.
>
> Signed-off-by: Chris Lalancette <clalance-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
>
Patch looks good.
Why did you define MIG_STAT_DIRTY_TRACK_FAIL and not
MIG_STAT_KVM_SET_DIRTY_TRACKING_FAILED ?
Also we need to make sure, in case of a failure, that 'status' is
updated and *s->has_error is freed. How about calling migrate_finish ?
Thanks,
Uri.
-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
next prev parent reply other threads:[~2008-01-24 11:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-23 19:46 [PATCH]: Make migration handle errors a little better Chris Lalancette
[not found] ` <4797997A.1050809-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2008-01-24 11:01 ` Uri Lublin [this message]
[not found] ` <47987021.6010203-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2008-01-24 19:22 ` Chris Lalancette
2008-01-24 19:41 ` Chris Lalancette
[not found] ` <4798EA06.5090202-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2008-01-27 13:15 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47987021.6010203@qumranet.com \
--to=uril-atkuwr5tajbwk0htik3j/w@public.gmane.org \
--cc=clalance-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.