From: Jon Loeliger <jdl@freescale.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: linuxppc-dev@ozlabs.org, Jon Loeliger <jdl@jdl.com>
Subject: Re: [PATCH 3/4 v4] POWERPC: Add initial iomega StorCenter board port.
Date: Thu, 24 Jan 2008 09:06:03 -0600 [thread overview]
Message-ID: <4798A95B.50304@freescale.com> (raw)
In-Reply-To: <20080124115018.69551acf.sfr@canb.auug.org.au>
Stephen Rothwell wrote:
> Hi Jon,
>> +
>> + dnp = of_find_node_by_type(NULL, "open-pic");
>> + if (dnp == NULL)
>> + return;
>> +
>> + prop = of_get_property(dnp, "reg", &size);
>> + if (prop == NULL)
>> + return;
>
> You need an of_node_put(dnp) before you return.
"Damn your eyes!"
Kumar, I'll send you a patch here...
jdl
prev parent reply other threads:[~2008-01-24 15:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-23 18:42 [PATCH 3/4 v4] POWERPC: Add initial iomega StorCenter board port Jon Loeliger
2008-01-24 0:50 ` Stephen Rothwell
2008-01-24 1:54 ` Kumar Gala
2008-01-24 15:07 ` Jon Loeliger
2008-01-24 15:06 ` Jon Loeliger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4798A95B.50304@freescale.com \
--to=jdl@freescale.com \
--cc=jdl@jdl.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.