From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755754AbYAXQF3 (ORCPT ); Thu, 24 Jan 2008 11:05:29 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752642AbYAXQFT (ORCPT ); Thu, 24 Jan 2008 11:05:19 -0500 Received: from mx1.redhat.com ([66.187.233.31]:44454 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752537AbYAXQFR (ORCPT ); Thu, 24 Jan 2008 11:05:17 -0500 Message-ID: <4798B724.8050208@redhat.com> Date: Thu, 24 Jan 2008 11:04:52 -0500 From: Jarod Wilson Organization: Red Hat, Inc. User-Agent: Thunderbird 2.0.0.9 (X11/20071115) MIME-Version: 1.0 To: Stefan Richter CC: linux1394-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, =?ISO-8859-1?Q?Kristian_H=F8gsberg?= , Nick Piggin Subject: Re: [PATCH 1/4] firewire: fw-sbp2: use device generation, not card generation References: <200711011453.35268.nickpiggin@yahoo.com.au> <4729A1BF.8010800@s5r6.in-berlin.de> In-Reply-To: X-Enigmail-Version: 0.95.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Stefan Richter wrote: > There was a small window where a login or reconnect job could use an > already updated card generation with an outdated node ID. We have to > use the fw_device.generation here, not the fw_card.generation, because > the generation must never be newer than the node ID when we emit a > transaction. This cannot be guaranteed with fw_card.generation. > > Furthermore, the target's and initiator's node IDs can be obtained from > fw_device and fw_card. Dereferencing their underlying topology objects > is not necessary. > > Signed-off-by: Stefan Richter Verified in concert with parts 2 and 3 as well as with 2, 3 and 4, to fix 'giving up on config rom' issues on multiple system and drive combinations that were previously affected. Signed-off-by: Jarod Wilson -- Jarod Wilson jwilson@redhat.com