All of lore.kernel.org
 help / color / mirror / Atom feed
From: "H. Peter Anvin" <hpa@zytor.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: Yinghai Lu <yhlu.kernel@gmail.com>,
	Jeremy Fitzhardinge <jeremy@goop.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] x86: trim ram need to check if mtrr is there v2
Date: Fri, 25 Jan 2008 07:47:54 -0800	[thread overview]
Message-ID: <479A04AA.9040202@zytor.com> (raw)
In-Reply-To: <20080125111219.GB20026@elte.hu>

Ingo Molnar wrote:
> * Yinghai Lu <yhlu.kernel@gmail.com> wrote:
> 
>> is_cpu(INTEL) already make sure we have mtrr_if got assigned and 
>> cpu_has_mtrr.
>>
>> may need to fix qemu instead...
> 
> no ...
> 
> lets not do non-sensical trimming of RAM, ok? Emit a warning but never 
> trim all of RAM and make the system unbootable. Trimmed RAM is something 
> that users can pester board/BIOS vendors with. Non-booting kernels is 
> something _we_ get pestered with ;-)
> 

*And* let's push a fix to Qemu/KVM as appropriate.

Last I checked Qemu never even turns caching on in %cr0, never mind gets 
the MTRRs right.  If it's advertising MTRRs, this is a problem.

	-hpa

  reply	other threads:[~2008-01-25 15:51 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-25  1:44 x86.git: mtrr trimming removes all memory under kvm Jeremy Fitzhardinge
2008-01-25  1:49 ` H. Peter Anvin
2008-01-25  2:21   ` Yinghai Lu
2008-01-25  2:32   ` Yinghai Lu
2008-01-25 10:52     ` Andi Kleen
2008-01-25  3:47   ` [PATCH] x86: trim ram need to check if mtrr is there v2 Yinghai Lu
2008-01-25  5:44     ` H. Peter Anvin
2008-01-25  7:50       ` Yinghai Lu
2008-01-25  7:43     ` Jeremy Fitzhardinge
2008-01-25  8:13       ` Yinghai Lu
2008-01-25  8:39         ` Yinghai Lu
2008-01-25 11:12         ` Ingo Molnar
2008-01-25 15:47           ` H. Peter Anvin [this message]
2008-01-25  8:42       ` [PATCH] x86: trim ram need to check if mtrr is there v3 Yinghai Lu
2008-01-25 11:09         ` Ingo Molnar
2008-01-25 18:55           ` Jeremy Fitzhardinge
2008-01-25 18:59             ` Ingo Molnar
2008-01-25 19:01               ` Jeremy Fitzhardinge
2008-01-25 19:04                 ` Ingo Molnar
2008-01-25 19:27                   ` Jeremy Fitzhardinge
2008-01-25 19:30                     ` Ingo Molnar
2008-01-25 19:32                     ` Yinghai Lu
2008-01-25 19:39                       ` Jeremy Fitzhardinge
2008-01-25 19:19             ` Yinghai Lu
2008-01-25 19:04               ` Jeremy Fitzhardinge
2008-01-25 18:59           ` Jeremy Fitzhardinge
2008-01-25 19:02             ` Ingo Molnar
2008-01-25 14:21         ` Ingo Molnar
2008-01-25 14:57           ` Andi Kleen
2008-01-25 15:10             ` Ingo Molnar
2008-01-25 15:57               ` H. Peter Anvin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=479A04AA.9040202@zytor.com \
    --to=hpa@zytor.com \
    --cc=jeremy@goop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=yhlu.kernel@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.