From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with archive (Exim 4.43)
	id 1JIrkW-0007pZ-Ow
	for mharc-grub-devel@gnu.org; Sat, 26 Jan 2008 15:35:36 -0500
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1JIrkV-0007ox-E3
	for grub-devel@gnu.org; Sat, 26 Jan 2008 15:35:35 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1JIrkT-0007nZ-CB
	for grub-devel@gnu.org; Sat, 26 Jan 2008 15:35:34 -0500
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1JIrkT-0007nG-57
	for grub-devel@gnu.org; Sat, 26 Jan 2008 15:35:33 -0500
Received: from pne-smtpout3-sn2.hy.skanova.net ([81.228.8.111])
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <chaac@nic.fi>) id 1JIrkS-0005RO-Va
	for grub-devel@gnu.org; Sat, 26 Jan 2008 15:35:33 -0500
Received: from [127.0.0.1] (88.193.32.97) by pne-smtpout3-sn2.hy.skanova.net
	(7.3.129) id 478BDB96000A8826 for grub-devel@gnu.org;
	Sat, 26 Jan 2008 21:34:32 +0100
Message-ID: <479B9993.3080405@nic.fi>
Date: Sat, 26 Jan 2008 22:35:31 +0200
From: =?UTF-8?B?VmVzYSBKw6TDpHNrZWzDpGluZW4=?= <chaac@nic.fi>
User-Agent: Thunderbird 2.0.0.9 (Windows/20071031)
MIME-Version: 1.0
To: The development of GRUB 2 <grub-devel@gnu.org>
References: <20080126194444.16214.26226.stgit@dv.roinet.com>	<20080126195937.GC6486@thorin>	<20080126151102.lo2xgh1bi88ksw4k@webmail.spamcop.net>
	<20080126202457.GA7323@thorin>
In-Reply-To: <20080126202457.GA7323@thorin>
X-Enigmail-Version: 0.95.6
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-detected-kernel: by monty-python.gnu.org: Solaris 10 (beta)
Subject: Re: [PATCH] Don't abort if prefix is not set
X-BeenThere: grub-devel@gnu.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: The development of GRUB 2 <grub-devel@gnu.org>
List-Id: The development of GRUB 2 <grub-devel.gnu.org>
List-Unsubscribe: <http://lists.gnu.org/mailman/listinfo/grub-devel>,
	<mailto:grub-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/grub-devel>
List-Post: <mailto:grub-devel@gnu.org>
List-Help: <mailto:grub-devel-request@gnu.org?subject=help>
List-Subscribe: <http://lists.gnu.org/mailman/listinfo/grub-devel>,
	<mailto:grub-devel-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sat, 26 Jan 2008 20:35:35 -0000

Robert Millan wrote:
> On Sat, Jan 26, 2008 at 03:11:02PM -0500, Pavel Roskin wrote:
>> Quoting Robert Millan <rmh@aybabtu.com>:
>>
>>>> +  if (! grub_dl_dir) {
>>>> +    grub_error (GRUB_ERR_FILE_NOT_FOUND, "\"prefix\" is not set");
>>>> +    return 0;
>>> Seems fine, but are you sure this error is handled somewhere?
>> If prefix is not set, the module is not loaded.  What other handling  
>> do we need?
> 
> What I mean is, is the error message printed?  I recall it had to be handled
> somewhere.  Or maybe I'm confused...

Whole error stack is printed just before prompt.