From: Randy Dunlap <randy.dunlap@oracle.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Konrad Rzeszutek <konrad@darnok.org>,
linux-kernel@vger.kernel.org, greg@kroah.com, dwm@enoyolf.org,
darnok@68k.org, pjones@redhat.com, konradr@redhat.com,
konradr@linux.vnet.ibm.com, hpa@zytor.com, lenb@kernel.org,
mike.anderson@us.ibm.com, dwm@austin.ibm.com,
arjan@infradead.org, michaelc@cs.wisc.edu,
Andy Whitcroft <apw@shadowen.org>
Subject: Re: [PATCH] Add iSCSI iBFT support (v0.4.5)
Date: Sun, 27 Jan 2008 08:47:36 -0800 [thread overview]
Message-ID: <479CB5A8.9050405@oracle.com> (raw)
In-Reply-To: <20080126220123.d20dd393.akpm@linux-foundation.org>
Andrew Morton wrote:
>> int __initdata user_defined_memmap = 0;
> checkpatch should have told you that this "= 0" shouldn't be there. But it
> doesn't.
checkpatch checks for static initializers, not non-static ones.
Should that be changed?
>> + for (pos = (u8 *)hdr; pos < (u8 *)hdr + len; pos ++)
>>
>
> checkpatch should have caught the " ++" but didn't. I think it used to.
> It seems to be going backwards?
--
~Randy
next prev parent reply other threads:[~2008-01-27 16:57 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-25 22:06 [PATCH] Add iSCSI iBFT support (v0.4.5) Konrad Rzeszutek
2008-01-27 6:01 ` Andrew Morton
2008-01-27 6:01 ` Andrew Morton
2008-01-27 16:47 ` Randy Dunlap [this message]
2008-01-28 11:27 ` Andy Whitcroft
2008-01-28 19:04 ` Konrad Rzeszutek
2008-01-28 19:11 ` Doug Maxey
2008-01-28 19:35 ` H. Peter Anvin
2008-01-28 20:46 ` Konrad Rzeszutek
2008-01-28 21:13 ` Peter Jones
2008-01-30 21:47 ` Konrad Rzeszutek
2008-01-29 19:13 ` Mike Christie
2008-01-29 19:44 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=479CB5A8.9050405@oracle.com \
--to=randy.dunlap@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=apw@shadowen.org \
--cc=arjan@infradead.org \
--cc=darnok@68k.org \
--cc=dwm@austin.ibm.com \
--cc=dwm@enoyolf.org \
--cc=greg@kroah.com \
--cc=hpa@zytor.com \
--cc=konrad@darnok.org \
--cc=konradr@linux.vnet.ibm.com \
--cc=konradr@redhat.com \
--cc=lenb@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michaelc@cs.wisc.edu \
--cc=mike.anderson@us.ibm.com \
--cc=pjones@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.