Re: [Xenomai-core] [PATCH] consistent xeno-config output

[Jan Kiszka <jan.kiszka@domain.hid>]

[-- Attachment #1: Type: text/plain, Size: 747 bytes --]

Gilles Chanteperdrix wrote:
> On Jan 28, 2008 11:28 AM, Jan Kiszka <jan.kiszka@domain.hid> wrote:
>> Gilles Chanteperdrix wrote:
>>> On Jan 28, 2008 11:10 AM, Jan Kiszka <jan.kiszka@domain.hid> wrote:
>>>> I received some complaint that xeno-config [--verbose] does not match
>>>> xeno-config --posix-ldflags. Here is a fix.
>>> Useless use of cat detected ! When parsing posix.wrappers, we could
>>> redirect input from posix.wrappers instead of using cat.
>>>
>> OK. Is this one better?
> 
> I would say there is still a useless use of backticks, why use:
> echo `posix_ldflags`
> instead of simply:
> posix_ldflags
> echo
> 
> ?

So shall it be. :)

Jan

-- 
Siemens AG, Corporate Technology, CT SE 2
Corporate Competence Center Embedded Linux

[-- Attachment #2: consistify-xeno-config-output-v3.patch --]
[-- Type: text/x-patch, Size: 3231 bytes --]

---
 ChangeLog              |    4 ++++
 scripts/xeno-config.in |   49 +++++++++++++++++++++++++++----------------------
 2 files changed, 31 insertions(+), 22 deletions(-)

Index: b/scripts/xeno-config.in
===================================================================
--- a/scripts/xeno-config.in
+++ b/scripts/xeno-config.in
@@ -23,6 +23,22 @@ XENO_LIBRARY_DIR="${staging}${libdir}"
 
 unset prefix exec_prefix libdir datadir datarootdir pkgdatadir includedir
 
+posix_ldflags ()
+{
+    if test \! -r $XENO_POSIX_WRAPPERS; then
+        echo "POSIX support is not available" >&2
+        exit 1
+    fi
+    if test "$XENO_POSIX_FAST_WRAPPING" = "yes"; then
+        echo -n "-Wl,@$XENO_POSIX_WRAPPERS $XENO_POSIX_LDFLAGS"
+    else
+        wrappers=`while read wrap_option symbol; do \
+                      echo -n "-Wl,$wrap_option,$symbol " ; \
+                  done < $XENO_POSIX_WRAPPERS`
+        echo -n "$wrappers $XENO_POSIX_LDFLAGS"
+    fi
+}
+
 usage ()
 {
 cat <<EOF
@@ -46,15 +62,15 @@ EOF
 verbose ()
 {
     echo xeno-config --verbose
-    echo "   " --version="\"${XENO_VERSION}\""
-    echo "   " --cc="\"$XENO_CC\""
-    echo "   " --arch="\"$XENO_TARGET_ARCH\""
-    echo "   " --prefix="\"$XENO_PREFIX\""
-    echo "   " --xeno-cflags="\"$XENO_BASE_CFLAGS\""
-    echo "   " --xeno-ldflags="\"$XENO_BASE_LDFLAGS\""
-    echo "   " --posix-cflags="\"$XENO_POSIX_CFLAGS\""
-    echo "   " --posix-ldflags="\"$XENO_POSIX_LDFLAGS\""
-    echo "   " --library-dir="\"$XENO_LIBRARY_DIR\""
+    echo "        --version=\"${XENO_VERSION}\""
+    echo "        --cc=\"$XENO_CC\""
+    echo "        --arch=\"$XENO_TARGET_ARCH\""
+    echo "        --prefix=\"$XENO_PREFIX\""
+    echo "        --xeno-cflags=\"$XENO_BASE_CFLAGS\""
+    echo "        --xeno-ldflags=\"$XENO_BASE_LDFLAGS\""
+    echo "        --posix-cflags=\"$XENO_POSIX_CFLAGS\""
+    echo "        --posix-ldflags=\"`posix_ldflags`\""
+    echo "        --library-dir=\"$XENO_LIBRARY_DIR\""
 }
 
 if test $# -eq 0; then
@@ -90,19 +106,8 @@ while test $# -gt 0; do
             echo $XENO_POSIX_CFLAGS
             ;;
         --posix-ldflags)
-            if test \! -r $XENO_POSIX_WRAPPERS; then
-               echo "POSIX support is not available" >&2
-               exit 1
-            fi
-            if test "$XENO_POSIX_FAST_WRAPPING" = "yes"; then
-                echo "-Wl,@$XENO_POSIX_WRAPPERS $XENO_POSIX_LDFLAGS"
-            else
-                wrappers=`cat $XENO_POSIX_WRAPPERS | \
-                    while read wrap_option symbol; do \
-                        echo -n "-Wl,$wrap_option,$symbol " ; \
-                    done`
-                echo "$wrappers $XENO_POSIX_LDFLAGS"
-            fi
+            posix_ldflags
+            echo
             ;;
         --lib*-dir|--libdir|--user-libdir)
             echo $XENO_LIBRARY_DIR
Index: b/ChangeLog
===================================================================
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,7 @@
+2008-01-26  Jan Kiszka  <jan.kiszka@domain.hid>
+
+	* scripts/xeno-config.in: Ensure consistent output of posix-ldflags.
+
 2008-01-27  Jan Kiszka  <jan.kiszka@domain.hid>
 
 	* ksrc/arch/x86/hal-common.c: Fix race when starting the cleanup