From: Tejun Heo <htejun@gmail.com>
To: Adrian Bunk <bunk@kernel.org>
Cc: Jeff Garzik <jeff@garzik.org>,
linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [2.6 patch] ata_piix.c: make piix_merge_scr() static
Date: Tue, 29 Jan 2008 08:02:28 +0900 [thread overview]
Message-ID: <479E5F04.3000009@gmail.com> (raw)
In-Reply-To: <20080128221019.GN8767@does.not.exist>
Adrian Bunk wrote:
> piix_merge_scr() can become static.
>
> Signed-off-by: Adrian Bunk <bunk@kernel.org>
>
> ---
> f272ad2ac4274a59f0b43cfd65488c51855132d4
> diff --git a/drivers/ata/ata_piix.c b/drivers/ata/ata_piix.c
> index a65c8ae..1a5c3bf 100644
> --- a/drivers/ata/ata_piix.c
> +++ b/drivers/ata/ata_piix.c
> @@ -1068,7 +1068,7 @@ static void piix_sidpr_write(struct ata_device *dev, unsigned int reg, u32 val)
> iowrite32(val, hpriv->sidpr + PIIX_SIDPR_DATA);
> }
>
> -u32 piix_merge_scr(u32 val0, u32 val1, const int * const *merge_tbl)
> +static u32 piix_merge_scr(u32 val0, u32 val1, const int * const *merge_tbl)
> {
> u32 val = 0;
> int i, mi;
Ah.. right. Thanks. I somehow forgot static in front of it.
Acked-by: Tejun Heo <htejun@gmail.com>
--
tejun
next prev parent reply other threads:[~2008-01-28 23:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-28 22:10 [2.6 patch] ata_piix.c: make piix_merge_scr() static Adrian Bunk
2008-01-28 23:02 ` Tejun Heo [this message]
2008-02-01 16:55 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=479E5F04.3000009@gmail.com \
--to=htejun@gmail.com \
--cc=bunk@kernel.org \
--cc=jeff@garzik.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.