All of lore.kernel.org
 help / color / mirror / Atom feed
From: Patrick McHardy <kaber@trash.net>
To: Jan Engelhardt <jengelh@computergmbh.de>
Cc: Netfilter Developer Mailing List <netfilter-devel@vger.kernel.org>
Subject: Re: [NETFILTER]: xt_hashlimit match, revision 1
Date: Tue, 29 Jan 2008 14:04:26 +0100	[thread overview]
Message-ID: <479F245A.2030509@trash.net> (raw)
In-Reply-To: <Pine.LNX.4.64.0801241946190.12676@fbirervta.pbzchgretzou.qr>

Jan Engelhardt wrote:
> Hi,
> 
> this patch was previously unmerged because it conflicted with Eric 
> Dumazet's changes. I now rediffed it; please apply.


This adds a huge number of sparse warnings, please fix those up.
I already fixed those in your other recent patches, but please
make sure all patches you submit are sparse warning free.

net/netfilter/xt_hashlimit.c:480:17: warning: incorrect type in argument 
1 (different base types)
net/netfilter/xt_hashlimit.c:480:17:    expected unsigned int [unsigned] 
[usertype] a
net/netfilter/xt_hashlimit.c:480:17:    got restricted unsigned int 
[usertype] <noident>
net/netfilter/xt_hashlimit.c:469:9: warning: cast to restricted type
net/netfilter/xt_hashlimit.c:469:9: warning: cast to restricted type
net/netfilter/xt_hashlimit.c:469:9: warning: cast to restricted type
net/netfilter/xt_hashlimit.c:469:9: warning: cast to restricted type
net/netfilter/xt_hashlimit.c:469:9: warning: cast to restricted type
net/netfilter/xt_hashlimit.c:469:9: warning: cast to restricted type
net/netfilter/xt_hashlimit.c:469:9: warning: cast to restricted type
net/netfilter/xt_hashlimit.c:469:9: warning: cast to restricted type
net/netfilter/xt_hashlimit.c:469:9: warning: cast to restricted type
net/netfilter/xt_hashlimit.c:469:9: warning: cast to restricted type
net/netfilter/xt_hashlimit.c:469:9: warning: cast to restricted type
net/netfilter/xt_hashlimit.c:469:9: warning: cast to restricted type
net/netfilter/xt_hashlimit.c:469:9: warning: cast to restricted type
net/netfilter/xt_hashlimit.c:469:9: warning: cast to restricted type
net/netfilter/xt_hashlimit.c:469:9: warning: cast to restricted type
net/netfilter/xt_hashlimit.c:469:9: warning: cast to restricted type
net/netfilter/xt_hashlimit.c:469:9: warning: cast to restricted type
net/netfilter/xt_hashlimit.c:469:9: warning: cast to restricted type
net/netfilter/xt_hashlimit.c:469:9: warning: cast to restricted type
net/netfilter/xt_hashlimit.c:469:9: warning: cast to restricted type
net/netfilter/xt_hashlimit.c:469:9: warning: cast to restricted type
net/netfilter/xt_hashlimit.c:469:9: warning: cast to restricted type
net/netfilter/xt_hashlimit.c:469:9: warning: cast to restricted type
net/netfilter/xt_hashlimit.c:469:9: warning: cast to restricted type
net/netfilter/xt_hashlimit.c:469:9: warning: cast to restricted type
net/netfilter/xt_hashlimit.c:469:9: warning: cast to restricted type
net/netfilter/xt_hashlimit.c:469:9: warning: cast to restricted type
net/netfilter/xt_hashlimit.c:469:9: warning: cast to restricted type
net/netfilter/xt_hashlimit.c:469:9: warning: cast to restricted type
net/netfilter/xt_hashlimit.c:469:9: warning: cast to restricted type
net/netfilter/xt_hashlimit.c:469:9: warning: cast to restricted type
net/netfilter/xt_hashlimit.c:469:9: warning: cast to restricted type
net/netfilter/xt_hashlimit.c:469:9: warning: cast to restricted type
net/netfilter/xt_hashlimit.c:469:9: warning: cast to restricted type
net/netfilter/xt_hashlimit.c:469:9: warning: cast to restricted type
net/netfilter/xt_hashlimit.c:469:9: warning: cast to restricted type
net/netfilter/xt_hashlimit.c:469:9: warning: incorrect type in return 
expression (different base types)
net/netfilter/xt_hashlimit.c:469:9:    expected unsigned int
net/netfilter/xt_hashlimit.c:469:9:    got restricted unsigned int 
[usertype] <noident>
net/netfilter/xt_hashlimit.c:480:8: warning: incorrect type in 
assignment (different base types)
net/netfilter/xt_hashlimit.c:480:8:    expected restricted unsigned int 
[usertype] <noident>
net/netfilter/xt_hashlimit.c:480:8:    got unsigned int
net/netfilter/xt_hashlimit.c:487:17: warning: incorrect type in argument 
1 (different base types)
net/netfilter/xt_hashlimit.c:487:17:    expected unsigned int [unsigned] 
[usertype] a
net/netfilter/xt_hashlimit.c:487:17:    got restricted unsigned int 
[usertype] <noident>
net/netfilter/xt_hashlimit.c:469:9: warning: cast to restricted type
net/netfilter/xt_hashlimit.c:469:9: warning: cast to restricted type
net/netfilter/xt_hashlimit.c:469:9: warning: cast to restricted type
net/netfilter/xt_hashlimit.c:469:9: warning: cast to restricted type
net/netfilter/xt_hashlimit.c:469:9: warning: cast to restricted type
net/netfilter/xt_hashlimit.c:469:9: warning: cast to restricted type
net/netfilter/xt_hashlimit.c:469:9: warning: cast to restricted type
net/netfilter/xt_hashlimit.c:469:9: warning: cast to restricted type
net/netfilter/xt_hashlimit.c:469:9: warning: cast to restricted type
net/netfilter/xt_hashlimit.c:469:9: warning: cast to restricted type
net/netfilter/xt_hashlimit.c:469:9: warning: cast to restricted type
net/netfilter/xt_hashlimit.c:469:9: warning: cast to restricted type
net/netfilter/xt_hashlimit.c:469:9: warning: cast to restricted type
net/netfilter/xt_hashlimit.c:469:9: warning: cast to restricted type
net/netfilter/xt_hashlimit.c:469:9: warning: cast to restricted type
net/netfilter/xt_hashlimit.c:469:9: warning: cast to restricted type
net/netfilter/xt_hashlimit.c:469:9: warning: cast to restricted type
net/netfilter/xt_hashlimit.c:469:9: warning: cast to restricted type
net/netfilter/xt_hashlimit.c:469:9: warning: cast to restricted type
net/netfilter/xt_hashlimit.c:469:9: warning: cast to restricted type
net/netfilter/xt_hashlimit.c:469:9: warning: cast to restricted type
net/netfilter/xt_hashlimit.c:469:9: warning: cast to restricted type
net/netfilter/xt_hashlimit.c:469:9: warning: cast to restricted type
net/netfilter/xt_hashlimit.c:469:9: warning: cast to restricted type
net/netfilter/xt_hashlimit.c:469:9: warning: cast to restricted type
net/netfilter/xt_hashlimit.c:469:9: warning: cast to restricted type
net/netfilter/xt_hashlimit.c:469:9: warning: cast to restricted type
net/netfilter/xt_hashlimit.c:469:9: warning: cast to restricted type
net/netfilter/xt_hashlimit.c:469:9: warning: cast to restricted type
net/netfilter/xt_hashlimit.c:469:9: warning: cast to restricted type
net/netfilter/xt_hashlimit.c:469:9: warning: cast to restricted type
net/netfilter/xt_hashlimit.c:469:9: warning: cast to restricted type
net/netfilter/xt_hashlimit.c:469:9: warning: cast to restricted type
net/netfilter/xt_hashlimit.c:469:9: warning: cast to restricted type
net/netfilter/xt_hashlimit.c:469:9: warning: cast to restricted type
net/netfilter/xt_hashlimit.c:469:9: warning: cast to restricted type
net/netfilter/xt_hashlimit.c:469:9: warning: incorrect type in return 
expression (different base types)
net/netfilter/xt_hashlimit.c:469:9:    expected unsigned int
net/netfilter/xt_hashlimit.c:469:9:    got restricted unsigned int 
[usertype] <noident>
net/netfilter/xt_hashlimit.c:487:8: warning: incorrect type in 
assignment (different base types)
net/netfilter/xt_hashlimit.c:487:8:    expected restricted unsigned int 
[usertype] <noident>
net/netfilter/xt_hashlimit.c:487:8:    got unsigned int
net/netfilter/xt_hashlimit.c:494:17: warning: incorrect type in argument 
1 (different base types)
net/netfilter/xt_hashlimit.c:494:17:    expected unsigned int [unsigned] 
[usertype] a
net/netfilter/xt_hashlimit.c:494:17:    got restricted unsigned int 
[usertype] <noident>
net/netfilter/xt_hashlimit.c:469:9: warning: cast to restricted type
net/netfilter/xt_hashlimit.c:469:9: warning: cast to restricted type
net/netfilter/xt_hashlimit.c:469:9: warning: cast to restricted type
net/netfilter/xt_hashlimit.c:469:9: warning: cast to restricted type
net/netfilter/xt_hashlimit.c:469:9: warning: cast to restricted type
net/netfilter/xt_hashlimit.c:469:9: warning: cast to restricted type
net/netfilter/xt_hashlimit.c:469:9: warning: cast to restricted type
net/netfilter/xt_hashlimit.c:469:9: warning: cast to restricted type
net/netfilter/xt_hashlimit.c:469:9: warning: cast to restricted type
net/netfilter/xt_hashlimit.c:469:9: warning: cast to restricted type
net/netfilter/xt_hashlimit.c:469:9: warning: cast to restricted type
net/netfilter/xt_hashlimit.c:469:9: warning: cast to restricted type
net/netfilter/xt_hashlimit.c:469:9: warning: cast to restricted type
net/netfilter/xt_hashlimit.c:469:9: warning: cast to restricted type
net/netfilter/xt_hashlimit.c:469:9: warning: cast to restricted type
net/netfilter/xt_hashlimit.c:469:9: warning: cast to restricted type
net/netfilter/xt_hashlimit.c:469:9: warning: cast to restricted type
net/netfilter/xt_hashlimit.c:469:9: warning: cast to restricted type
net/netfilter/xt_hashlimit.c:469:9: warning: cast to restricted type
net/netfilter/xt_hashlimit.c:469:9: warning: cast to restricted type
net/netfilter/xt_hashlimit.c:469:9: warning: too many warnings

  parent reply	other threads:[~2008-01-29 13:20 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-24 18:48 [NETFILTER]: xt_hashlimit match, revision 1 Jan Engelhardt
2008-01-24 18:50 ` [RESEND][NETFILTER]: " Jan Engelhardt
2008-01-29 13:04 ` Patrick McHardy [this message]
2008-01-29 15:25   ` [NETFILTER]: " Jan Engelhardt
2008-01-29 15:31     ` Patrick McHardy
2008-01-29 17:07       ` Jan Engelhardt
2008-01-29 17:14         ` Patrick McHardy
2008-01-29 17:21           ` Jan Engelhardt
2008-01-29 17:24             ` Patrick McHardy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=479F245A.2030509@trash.net \
    --to=kaber@trash.net \
    --cc=jengelh@computergmbh.de \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.