Re: [PATCH 1/5][IPTABLES]: Import netfilter.h

[Patrick McHardy <kaber@trash.net>]

Jan Engelhardt wrote:
> On Jan 29 2008 14:10, Patrick McHardy wrote:
>> Subject: Re: [PATCH 1/5][IPTABLES]: Import netfilter.h
>>
>> Jan Engelhardt wrote:
>>> Import netfilter.h from kernel to get hold of union nf_inet_addr
>>> and fix a compile error in current iptable tarball releases when
>>> used with non-development kernels.
>> We already have this exact file in the current sources, without
>> the #ifdef __KERNEL__ parts.
>>
> 
> Where? If you mean the sanitized headers in 
> /usr/include/linux/netfilter.h -- this file is outdated and does not 
> ship the nf_inet_addr definition.

You're right, I only added it locally, but forgot "svn add" :)
Committed now.

> Since we copy all xt_{match,target}*.h header files too, I thought doing 
> the same for netfilter.h is ok.
> 
> I do believe it is, because the sanitized headers in 
> /usr/include/linux/netfilter/ are _also_ out-of-date.
> BTW, could we, perhaps, remove headers-y for 
> /usr/include/linux/netfilter/, since iptables ships it anyway?

No, there are other users of these files. I recall there is
some perl interface for iptables for example.