Re: swapping with MMU Notifiers V2

[Avi Kivity <avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org>]

Carsten Otte wrote:
>>  #include <linux/kvm.h>
>> @@ -118,6 +119,7 @@ struct kvm {
>>  	struct kvm_io_bus pio_bus;
>>  	struct kvm_vm_stat stat;
>>  	struct kvm_arch arch;
>> +	struct mmu_notifier mmu_notifier;
>>  };
>>
>>  /* The guest did something we don't support. */
>>     
> This should not be in struct kvm, it should go to x86's kvm_arch. This 
> is x86 specific, we don't need a notifier since the core-vm will just 
> page out our guest memory like regular userspace mem.
>
>   

Every arch except s390 needs it.  An ugly #ifndef 
CONFIG_KVM_HARDWARE_TLB_SYNC is preferred to duplicating the code.

-- 
error compiling committee.c: too many arguments to function


-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/