From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pat Campbell Subject: [RFC][PATCH][ioemu] strip tap:aio from param Date: Tue, 29 Jan 2008 13:06:37 -0700 Message-ID: <479F874D.6040803@novell.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------000600000607050704020408" Return-path: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: "xen-devel@lists.xensource.com" List-Id: xen-devel@lists.xenproject.org This is a multi-part message in MIME format. --------------000600000607050704020408 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Currently I am not able to mount or boot from an HVM CDROM when it is configured for 'tap:aio' instead of 'file'. disk=[ 'tap:aio:/var/lib/xen/images/sles10-sp2-fv/disk0,hda,w', ' tap:aio:/home/iso/sles/SLES10.iso,hdc:cdrom,r', ] With the attached patch I am able to boot from the CDROM and or mount it. Patch against xen-unstable tip changes xenstore.c:xenstore_parse_domain_config() to rewrite param to xenstore without the tap:aio prefix. This allows xenstore_process_event() to read the correct image name. It might be better to filter out aio in xenstore_process_event() instead of changing param in xenstore. Anybody have an opinion on that? I will submit a real patch once I have some feedback. Pat --------------000600000607050704020408 Content-Type: text/x-patch; name="xen-tap-aio.patch" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="xen-tap-aio.patch" diff -r 1c826ea72a80 tools/ioemu/xenstore.c --- a/tools/ioemu/xenstore.c Wed Jan 23 15:42:52 2008 +0000 +++ b/tools/ioemu/xenstore.c Tue Jan 29 12:42:24 2008 -0700 @@ -182,6 +182,8 @@ void xenstore_parse_domain_config(int do if (!offset) continue ; memmove(params, offset+1, strlen(offset+1)+1 ); + if (pasprintf(&buf, "%s/params", bpath) == 0) + xs_write(xsh, XBT_NULL, buf, params, strlen(params)); fprintf(logfile, "Strip off blktap sub-type prefix to %s\n", params); } --------------000600000607050704020408 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel --------------000600000607050704020408--