From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759387AbYA2UoE (ORCPT ); Tue, 29 Jan 2008 15:44:04 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754054AbYA2Unu (ORCPT ); Tue, 29 Jan 2008 15:43:50 -0500 Received: from bzq-179-150-194.static.bezeqint.net ([212.179.150.194]:56585 "EHLO il.qumranet.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752896AbYA2Unt (ORCPT ); Tue, 29 Jan 2008 15:43:49 -0500 Message-ID: <479F8F83.2030809@qumranet.com> Date: Tue, 29 Jan 2008 22:41:39 +0200 From: Avi Kivity User-Agent: Thunderbird 2.0.0.9 (X11/20071115) MIME-Version: 1.0 To: Christoph Lameter CC: Andrea Arcangeli , Robin Holt , Izik Eidus , Nick Piggin , kvm-devel@lists.sourceforge.net, Benjamin Herrenschmidt , Peter Zijlstra , steiner@sgi.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, daniel.blueman@quadrics.com, Hugh Dickins Subject: Re: [patch 1/6] mmu_notifier: Core code References: <20080128202840.974253868@sgi.com> <20080128202923.609249585@sgi.com> <20080129135914.GF7233@v2.random> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.0rc1 (firebolt.argo.co.il [0.0.0.0]); Tue, 29 Jan 2008 22:41:39 +0200 (IST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Christoph Lameter wrote: > On Tue, 29 Jan 2008, Andrea Arcangeli wrote: > > >>> + struct mmu_notifier_head mmu_notifier; /* MMU notifier list */ >>> }; >>> >> Not sure why you prefer to waste ram when MMU_NOTIFIER=n, this is a >> regression (a minor one though). >> > > Andrew does not like #ifdefs and it makes it possible to verify calling > conventions if !CONFIG_MMU_NOTIFIER. > > You could define mmu_notifier_head as an empty struct in that case. -- Do not meddle in the internals of kernels, for they are subtle and quick to panic. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [patch 1/6] mmu_notifier: Core code Date: Tue, 29 Jan 2008 22:41:39 +0200 Message-ID: <479F8F83.2030809@qumranet.com> References: <20080128202840.974253868@sgi.com> <20080128202923.609249585@sgi.com> <20080129135914.GF7233@v2.random> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: Nick Piggin , Andrea Arcangeli , Peter Zijlstra , linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org, Benjamin Herrenschmidt , steiner-sJ/iWh9BUns@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, daniel.blueman-xqY44rlHlBpWk0Htik3J/w@public.gmane.org, Robin Holt , Hugh Dickins To: Christoph Lameter Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org Christoph Lameter wrote: > On Tue, 29 Jan 2008, Andrea Arcangeli wrote: > > >>> + struct mmu_notifier_head mmu_notifier; /* MMU notifier list */ >>> }; >>> >> Not sure why you prefer to waste ram when MMU_NOTIFIER=n, this is a >> regression (a minor one though). >> > > Andrew does not like #ifdefs and it makes it possible to verify calling > conventions if !CONFIG_MMU_NOTIFIER. > > You could define mmu_notifier_head as an empty struct in that case. -- Do not meddle in the internals of kernels, for they are subtle and quick to panic. ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ From mboxrd@z Thu Jan 1 00:00:00 1970 Message-ID: <479F8F83.2030809@qumranet.com> Date: Tue, 29 Jan 2008 22:41:39 +0200 From: Avi Kivity MIME-Version: 1.0 Subject: Re: [patch 1/6] mmu_notifier: Core code References: <20080128202840.974253868@sgi.com> <20080128202923.609249585@sgi.com> <20080129135914.GF7233@v2.random> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org Return-Path: To: Christoph Lameter Cc: Andrea Arcangeli , Robin Holt , Izik Eidus , Nick Piggin , kvm-devel@lists.sourceforge.net, Benjamin Herrenschmidt , Peter Zijlstra , steiner@sgi.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, daniel.blueman@quadrics.com, Hugh Dickins List-ID: Christoph Lameter wrote: > On Tue, 29 Jan 2008, Andrea Arcangeli wrote: > > >>> + struct mmu_notifier_head mmu_notifier; /* MMU notifier list */ >>> }; >>> >> Not sure why you prefer to waste ram when MMU_NOTIFIER=n, this is a >> regression (a minor one though). >> > > Andrew does not like #ifdefs and it makes it possible to verify calling > conventions if !CONFIG_MMU_NOTIFIER. > > You could define mmu_notifier_head as an empty struct in that case. -- Do not meddle in the internals of kernels, for they are subtle and quick to panic. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org