All of lore.kernel.org
 help / color / mirror / Atom feed
From: Miloslav Trmac <mitr@redhat.com>
To: John Dennis <jdennis@redhat.com>
Cc: linux-audit@redhat.com
Subject: Re: Kernel audit output is inconsistent, hard to parse
Date: Wed, 30 Jan 2008 00:37:33 +0100	[thread overview]
Message-ID: <479FB8BD.6010902@redhat.com> (raw)
In-Reply-To: <479FAF24.8050109@redhat.com>

Hello,
John Dennis napsal(a):
> The current formatting of the record timestamp
> (e.g. audit(ssss.mmm:iii) is inconsistent with
> all other name/value pairs. It should be "seconds="sss"
> milliseconds="mmm" serial="iii", this allows parsing to be regular and
> consistent.
Isn't this unnecessarily verbose?  Just
    time="sss.mmm" serial="iii"
would be smaller, easier to read - and it would allow using better time 
precision in the future.

> It's a judgment call over when and how to introduce change
> and the anticipated impact.
If this change is implemented, we should use the opportunity to clean up 
other inconsistencies in audit messages - e.g. different messages use 
"success", "res" and "result" fields to record whether the audited 
operation was successful.

Also note that similar changes are necessary in user-space, e.g.
   type=USER_ERR ...: ... msg='PAM: bad_ident acct=? : 
exe="/usr/sbin/gdm-binary" (hostname=?, addr=?, terminal=? res=failed)'
contains name-value pairs within a value, using both pairs of quotes.
	Mirek

  reply	other threads:[~2008-01-29 23:37 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-29 22:56 Kernel audit output is inconsistent, hard to parse John Dennis
2008-01-29 23:37 ` Miloslav Trmac [this message]
2008-01-30  1:15   ` John Dennis
2008-01-30 14:21 ` Steve Grubb
2008-01-30 15:34   ` Paul Moore
2008-01-30 16:01     ` Steve Grubb
2008-01-30 16:35       ` Paul Moore
2008-01-30 16:39     ` Eric Paris
2008-01-30 16:41       ` Eric Paris
2008-01-30 16:19   ` John Dennis
2008-01-30 14:26 ` Paul Moore
2008-01-30 16:30 ` Eric Paris
2008-01-30 17:43   ` John Dennis
2008-01-31 21:11 ` Linda Knippers
2008-01-31 21:21   ` Steve Grubb
2008-01-31 21:59     ` Paul Moore
2008-01-31 22:43       ` Casey Schaufler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=479FB8BD.6010902@redhat.com \
    --to=mitr@redhat.com \
    --cc=jdennis@redhat.com \
    --cc=linux-audit@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.