From: Paulo Marques <pmarques@grupopie.com>
To: Bryan Wu <bryan.wu@analog.com>
Cc: linux-kernel@vger.kernel.org, Robin Getz <robin.getz@analog.com>
Subject: Re: [PATCH 1/1] [Kallsyms] Blackfin: Allow kernel symbols in L1 to be found
Date: Wed, 30 Jan 2008 11:17:14 +0000 [thread overview]
Message-ID: <47A05CBA.2030903@grupopie.com> (raw)
In-Reply-To: <1201688453-1763-1-git-send-email-bryan.wu@analog.com>
Bryan Wu wrote:
> From: Robin Getz <robin.getz@analog.com>
> [...]
> --- a/scripts/kallsyms.c
> +++ b/scripts/kallsyms.c
> @@ -12,6 +12,8 @@
> * (25/Aug/2004) Paulo Marques <pmarques@grupopie.com>
> * Changed the compression method from stem compression to "table lookup"
> * compression
> + * (10/Jul/2006) Robin Getz <rgetz@blackfin.uclinux.org>
> + * Add _stext_l1, _etext_l1 for the L1 memory section in Blackfin.
When I wrote this initially, it was a mistake to add a Changelog in the
first place, but I didn't know better at the time.
If you're going to make changes to this file, please remove all the
Changelog, instead of adding more entries to it. The "Changelog" should
be kept by the version control system, and not the source code itself.
The rest of the patch looks ok, though.
--
Paulo Marques - www.grupopie.com
"Very funny Scotty. Now beam up my clothes."
next prev parent reply other threads:[~2008-01-30 11:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-30 10:20 [PATCH 1/1] [Kallsyms] Blackfin: Allow kernel symbols in L1 to be found Bryan Wu
2008-01-30 11:17 ` Paulo Marques [this message]
2008-01-30 17:27 ` Bryan Wu
2008-01-30 17:48 ` [PATCH 1/1 try #2] " Bryan Wu
2008-01-30 17:49 ` [PATCH] [Scripts] kallsyms: Nuke all ChangeLog, this should be logged by git Bryan Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47A05CBA.2030903@grupopie.com \
--to=pmarques@grupopie.com \
--cc=bryan.wu@analog.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robin.getz@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.