From: Roel Kluin <12o3l@tiscali.nl>
To: mchan@broadcom.com, lkml <linux-kernel@vger.kernel.org>
Cc: netdev@vger.kernel.org
Subject: [drivers/net/bnx2.c] ADVERTISE_1000XPSE_ASYM
Date: Wed, 30 Jan 2008 15:07:44 +0100 [thread overview]
Message-ID: <47A084B0.1000301@tiscali.nl> (raw)
In drivers/net/bnx2.c:1285: it reads in function bnx2_setup_remote_phy():
if (pause_adv & (ADVERTISE_1000XPSE_ASYM | ADVERTISE_1000XPSE_ASYM))
Note that the two are the same and this is therefore equivalent to
if (pause_adv & ADVERTISE_1000XPSE_ASYM)
This appears to be incorrect, was maybe '| ADVERTISE_1000XPAUSE' intended?
next reply other threads:[~2008-01-30 14:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-30 14:07 Roel Kluin [this message]
2008-01-30 18:51 ` [drivers/net/bnx2.c] ADVERTISE_1000XPSE_ASYM Michael Chan
2008-02-01 1:07 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47A084B0.1000301@tiscali.nl \
--to=12o3l@tiscali.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=mchan@broadcom.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.