All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nicolas Ferre <nicolas.ferre@atmel.com>
To: Pierre Ossman <drzeus@drzeus.cx>
Cc: Marc Pignat <marc.pignat@hevs.ch>,
	Andrew Victor <avictor.za@gmail.com>,
	ARM Linux Mailing List  <linux-arm-kernel@lists.arm.linux.org.uk>,
	Linux Kernel list <linux-kernel@vger.kernel.org>
Subject: [PATCH] at91_mci: minor cleanup
Date: Wed, 30 Jan 2008 17:45:48 +0100	[thread overview]
Message-ID: <47A0A9BC.7090705@atmel.com> (raw)
In-Reply-To: <200801151444.21140.marc.pignat@hevs.ch>

From: Marc Pignat <marc.pignat@hevs.ch>

MMC_POWER_ON is a noop, no need to set the power pin again.

Signed-off-by: Marc Pignat <marc.pignat@hevs.ch>
Signed-off-by: Nicolas Ferre <nicolas.ferre@atmel.com>
---
MMC_POWER_OFF/MMC_POWER_UP turn the power OFF/ON, there is nothing to change
when ios->power_mode==MMC_POWER_ON.

Also changed indentation for the switch (CodingStyle), because there is no other
switch statement in this driver.

--- a/drivers/mmc/host/at91_mci.c
+++ b/drivers/mmc/host/at91_mci.c
@@ -658,13 +658,14 @@ static void at91_mci_set_ios(struct mmc_
 	/* maybe switch power to the card */
 	if (host->board->vcc_pin) {
 		switch (ios->power_mode) {
-			case MMC_POWER_OFF:
-				at91_set_gpio_value(host->board->vcc_pin, 0);
-				break;
-			case MMC_POWER_UP:
-			case MMC_POWER_ON:
-				at91_set_gpio_value(host->board->vcc_pin, 1);
-				break;
+		case MMC_POWER_OFF:
+			at91_set_gpio_value(host->board->vcc_pin, 0);
+			break;
+		case MMC_POWER_UP:
+			at91_set_gpio_value(host->board->vcc_pin, 1);
+			break;
+		default:
+			break;
 		}
 	}
 }



       reply	other threads:[~2008-01-30 16:46 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <200801151444.21140.marc.pignat@hevs.ch>
2008-01-30 16:45 ` Nicolas Ferre [this message]
2008-02-05  6:52   ` [PATCH] at91_mci: minor cleanup Pierre Ossman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47A0A9BC.7090705@atmel.com \
    --to=nicolas.ferre@atmel.com \
    --cc=avictor.za@gmail.com \
    --cc=drzeus@drzeus.cx \
    --cc=linux-arm-kernel@lists.arm.linux.org.uk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marc.pignat@hevs.ch \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.