From: Divy Le Ray <divy@chelsio.com>
To: Krishna Kumar <krkumar2@in.ibm.com>
Cc: jeff@garzik.org, netdev@vger.kernel.org, davem@davemloft.net
Subject: Re: [PATCH] Optimize cxgb3 xmit path (a bit)
Date: Wed, 30 Jan 2008 16:04:35 -0800 [thread overview]
Message-ID: <47A11093.10301@chelsio.com> (raw)
In-Reply-To: <20080130070016.29078.94125.sendpatchset@N20wks267652wss.in.ibm.com>
Krishna Kumar wrote:
> Changes:
> 1. Add common code for stopping queue.
> 2. No need to call netif_stop_queue followed by netif_wake_queue (and
> infact a netif_start_queue could have been used instead), instead
> call stop_queue if required, and remove code under USE_GTS macro.
> 3. There is no need to check for netif_queue_stopped, as the network
> core guarantees that for us (I am sure every driver could remove
> that check, eg e1000 - I have tested that path a few billion times
> with about a few hundred thousand qstops but the condition never
> hit even once).
>
> Thanks,
>
Hi Krishna,
Thanks for the work.
There is however a bit more cleaning to do regarding the USE_GTS macro.
I'll post a patch soon that will take your points in account.
Cheers,
Divy
prev parent reply other threads:[~2008-01-31 0:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-30 7:00 [PATCH] Optimize cxgb3 xmit path (a bit) Krishna Kumar
2008-01-30 7:05 ` Krishna Kumar2
2008-01-31 0:04 ` Divy Le Ray [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47A11093.10301@chelsio.com \
--to=divy@chelsio.com \
--cc=davem@davemloft.net \
--cc=jeff@garzik.org \
--cc=krkumar2@in.ibm.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.