From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gerd Hoffmann Subject: Re: [RFC] Dynamic modes support for PV xenfb (included) Date: Thu, 31 Jan 2008 09:22:40 +0100 Message-ID: <47A18550.9020204@redhat.com> References: <479D2669.5060105@novell.com> <87hcgv643k.fsf@pike.pond.sub.org> <47A07E7E.6040601@novell.com> <87sl0fxl5j.fsf@pike.pond.sub.org> <47A0DDB4.20103@novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <47A0DDB4.20103@novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Pat Campbell Cc: Derek Murray , "xen-devel@lists.xensource.com" , "Daniel P. Berrange" , Markus Armbruster List-Id: xen-devel@lists.xenproject.org Pat Campbell wrote: > Markus Armbruster wrote: >> I can't see how using grants for the page directory is an improvement >> over your previous iteration, which used pd[]. Can you explain? >> > I will try, I am not the greatest communicator lately. The real question is why stop half-way with the grant tables conversion? You should put grant references instead of mfns into the page list pages, i.e. map the framebuffer itself using grants too. That will kill even more 32/64 bit differences btw. > While I was working on this I "briefly" looked at the grant APIs to see > how hard it would be to create a new API that allocates and claims a > continuous block of references. You don't need that. xc_gnttab_map_grant_refs() takes a list of grant refs and creates a linear mapping of those for you. Only problem is that gntdev has a 128 grants limit, this needs fixing. Derek? cheers, Gerd -- http://kraxel.fedorapeople.org/xenner/