Re: [Qemu-devel] [PATCH] x86 Multiboot support (extended)

[Kevin Wolf <kwolf@suse.de>]

Hi,

I like this idea. When I just tried to load my multiboot kernel it
failed, though, because of the following piece of code:

> +    // XXX: multiboot header may be within the first 8192 bytes, but header
> +    //      is only the first 1024
> +        
> +    // Ok, let's see if it is a multiboot image
> +    for(i=0; i<(256 - 12); i+=4) { // the header is 12x32bit long
> +        if(ldl_p(header+i) == 0x1BADB002) {

I wonder if there is any reason why you didn't just replace the 1024 by
8192 in load_linux but added an XXX. Would this cause any problems I
missed? With this change and replacing 256 by 8192 in the above code it
works for my kernel, too.

Anyway, I think the for condition should be i < 4 * (256 - 12), even
without changing the 1024.

Kevin