Re: [PATCH] [VLAN] vlan_dev: Initialize dev pointer only when it is being used

[Patrick McHardy <kaber@trash.net>]

Benjamin Li wrote:
> Signed-off-by: Benjamin Li <ben@wenli.org>
> ---
>  net/8021q/vlan_dev.c |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/net/8021q/vlan_dev.c b/net/8021q/vlan_dev.c
> index 8059fa4..2fa5d68 100644
> --- a/net/8021q/vlan_dev.c
> +++ b/net/8021q/vlan_dev.c
> @@ -49,7 +49,7 @@
>   */
>  static int vlan_dev_rebuild_header(struct sk_buff *skb)
>  {
> -	struct net_device *dev = skb->dev;
> +	struct net_device *dev;
>  	struct vlan_ethhdr *veth = (struct vlan_ethhdr *)(skb->data);
>  
>  	switch (veth->h_vlan_encapsulated_proto) {
> @@ -60,6 +60,7 @@ static int vlan_dev_rebuild_header(struct sk_buff *skb)
>  		return arp_find(veth->h_dest, skb);
>  #endif
>  	default:
> +		dev = skb->dev;
>  		pr_debug("%s: unable to resolve type %X addresses.\n",
>  			 dev->name, ntohs(veth->h_vlan_encapsulated_proto));


This seems pretty pointless to me.