From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christian Ehrhardt Date: Thu, 31 Jan 2008 15:00:51 +0000 Subject: Re: [kvm-ppc-devel] [PATCH] [3/4] Add userpace tlb access Message-Id: <47A1E2A3.9080601@linux.vnet.ibm.com> List-Id: References: <12016963202210-git-send-email-ehrhardt@linux.vnet.ibm.com> In-Reply-To: <12016963202210-git-send-email-ehrhardt@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable To: kvm-ppc@vger.kernel.org Christian Ehrhardt wrote: > Hollis Blanchard wrote: >> On Wed, 2008-01-30 at 13:31 +0100, ehrhardt@linux.vnet.ibm.com wrote: >>> [...] >>> +struct tlbe { >>> + __u32 tid; /* Only the low 8 bits are used. */ >>> + __u32 word0; >>> + __u32 word1; >>> + __u32 word2; >>> +}; >> This definitely must be renamed. >=20 > I'll add a renaming patch on top when I resend the patches next time. Well I skipped that to have time for virtio, we can do it anytime between n= ow and the merge of e500. The main question before just renaming these structures is how do we want t= o integrate multiple sub-architectures here - ifdefs, including separate headers, union in tlbe = struct, ... - is this already decided ? Maybe it is ok to let it as is atm and wait for Zhang Wei's merge which wil= l bring in his tlbe style anyway. --=20 Gr=FCsse / regards,=20 Christian Ehrhardt IBM Linux Technology Center, Open Virtualization ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ _______________________________________________ kvm-ppc-devel mailing list kvm-ppc-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/kvm-ppc-devel