All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chuck Ebbert <cebbert@redhat.com>
To: Patrick McHardy <kaber@trash.net>
Cc: Netdev <netdev@vger.kernel.org>,
	Netfilter Development Mailinglist
	<netfilter-devel@vger.kernel.org>
Subject: Re: Still oopsing in nf_nat_move_storage()
Date: Thu, 31 Jan 2008 13:03:03 -0500	[thread overview]
Message-ID: <47A20D57.5040907@redhat.com> (raw)
In-Reply-To: <479F5FDC.5040903@trash.net>

On 01/29/2008 12:18 PM, Patrick McHardy wrote:
> Chuck Ebbert wrote:
>> nf_nat_move_storage():
>> /usr/src/debug/kernel-2.6.23/linux-2.6.23.i686/net/ipv4/netfilter/nf_nat_core.c:612
>>
>>       87:       f7 47 64 80 01 00 00    testl  $0x180,0x64(%edi)
>>       8e:       74 39                   je     c9
>> <nf_nat_move_storage+0x65>
>>
>> line 612:
>>         if (!(ct->status & IPS_NAT_DONE_MASK))
>>                 return;
>>
>> ct is NULL
> 
> The current kernel (and 2.6.23-stable) have:
> 
>         if (!ct || !(ct->status & IPS_NAT_DONE_MASK))
>                 return;
> 
> so it seems you're using an old version.

Sorry, I re-used the analysis from before that change went in. I now
have an oops report from 2.6.23.14 on x86_64.

It is oopsing there, and only on x86_64 now, because x86_64 refuses to
use a non-canonical address. ct contains what appears to be ASCII data.
i386 might be dereferencing some random address instead of oopsing...


   0:   48 f7 45 78 80 01 00    testq  $0x180,0x78(%rbp)
   7:   00
   8:   74 4c                   je     0x56
   a:   48 c7 c7 e0 18 28 88    mov    $0xffffffff882818e0,%rdi

%rbp has a bogus (non-canonical) address. On i386 there is no such test possible
so it will just dereference the address if it is mapped.

%rbp contains 8 valid ASCII chars: "salcf x\"


  reply	other threads:[~2008-01-31 18:03 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-29 17:11 Still oopsing in nf_nat_move_storage() Chuck Ebbert
2008-01-29 17:18 ` Patrick McHardy
2008-01-31 18:03   ` Chuck Ebbert [this message]
2008-02-01 23:41     ` Chuck Ebbert
2008-02-02 10:26       ` Patrick McHardy
2008-02-02 11:02       ` Patrick McHardy
2008-02-05 16:26         ` Thomas Woerner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47A20D57.5040907@redhat.com \
    --to=cebbert@redhat.com \
    --cc=kaber@trash.net \
    --cc=netdev@vger.kernel.org \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.